From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH 4/5] rtc: jz4740_rtc: Add support for acting as the system power controller Date: Thu, 17 Mar 2016 13:20:58 +0100 Message-ID: <20160317122058.GE3362@piout.net> References: <1457217531-26064-1-git-send-email-paul@crapouillou.net> <1457217531-26064-4-git-send-email-paul@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1457217531-26064-4-git-send-email-paul-icTtO2rgO2OTuSrc4Mpeew@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Paul Cercueil Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ralf Baechle , Alessandro Zummo , Paul Burton , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org On 05/03/2016 at 23:38:50 +0100, Paul Cercueil wrote : > + if (of_device_is_system_power_controller(pdev->dev.of_node)) { > + if (!pm_power_off) { > + /* Default: 60ms */ > + rtc->reset_pin_assert_time = 60; > + device_property_read_u32(&pdev->dev, It is probably more efficient to use of_property_read_u32 directly. Any particular reason to use device_property_read_u32? > + } else { > + dev_err(&pdev->dev, > + "Poweroff handler already present!\n"); I'm not found of that alignement, it is probably better to let the string go over 80 chars. checkpatch will not complain. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html