From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 1/2] video: goldfishfb: add devicetree bindings Date: Fri, 18 Mar 2016 11:23:26 -0500 Message-ID: <20160318162326.GA10559@rob-hp-laptop> References: <20160310153845.8996.17736.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160310153845.8996.17736.stgit-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alan Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tomi.valkeinen-l0cyMroinI0@public.gmane.org, plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Mar 10, 2016 at 03:39:00PM +0000, Alan wrote: > From: Greg Hackmann > > Add device tree bindings to the Goldfish frame buffer interface. > > Signed-off-by: Greg Hackmann > Signed-off-by: Jin Qian > Signed-off-by: Alan Cox > --- [...] > diff --git a/drivers/video/fbdev/goldfishfb.c b/drivers/video/fbdev/goldfishfb.c > index 7f6c9e6..f0e651b 100644 > --- a/drivers/video/fbdev/goldfishfb.c > +++ b/drivers/video/fbdev/goldfishfb.c > @@ -304,12 +304,19 @@ static int goldfish_fb_remove(struct platform_device *pdev) > return 0; > } > > +static const struct of_device_id goldfish_fb_of_match[] = { > + { .compatible = "google,goldfish-fb", }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, goldfish_fb_of_match); > > static struct platform_driver goldfish_fb_driver = { > .probe = goldfish_fb_probe, > .remove = goldfish_fb_remove, > .driver = { > - .name = "goldfish_fb" > + .name = "goldfish_fb", > + .owner = THIS_MODULE, This can be dropped. Otherwise, Acked-by: Rob Herring > + .of_match_table = goldfish_fb_of_match, > } > }; > > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html