From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: Re: [PATCH] ARM: dts: sun6i: Add serial0 alias and stdout-path to a31s-primo81.dts Date: Mon, 21 Mar 2016 08:50:21 +0100 Message-ID: <20160321075021.GY30977@lukather> References: <1458137962-27714-1-git-send-email-hdegoede@redhat.com> <20160318174839.GQ30977@lukather> <56ED184B.9000609@redhat.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hU50fLDIZPaBYjJk" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <56ED184B.9000609-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Hans de Goede Cc: Chen-Yu Tsai , linux-arm-kernel , devicetree , linux-sunxi , Karsten Merker List-Id: devicetree@vger.kernel.org --hU50fLDIZPaBYjJk Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Sat, Mar 19, 2016 at 10:13:47AM +0100, Hans de Goede wrote: > Hi, > > On 18-03-16 18:48, Maxime Ripard wrote: > >On Thu, Mar 17, 2016 at 02:28:03PM +0800, Chen-Yu Tsai wrote: > >>On Wed, Mar 16, 2016 at 10:19 PM, Hans de Goede wrote: > >>>u-boot uses the kernel as the canonical source for its sunxi dts files > >>>and u-boot needs these. > >>> > >>>Signed-off-by: Hans de Goede > >> > >>Acked-by: Chen-Yu Tsai > > > >Queued, thanks! > > I just got an of-list mail from Karsten Merker that you nacked the addition > if this during the initial submission, because there are no accessible uart > test pads on this tablet. > > In that case the proper fix would be to change the u-boot defconfig to have: > > # CONFIG_REQUIRE_SERIAL_CONSOLE is not set > > Which will stop u-boot from panicking (with nowhere to print the panic msg) > when it has no stdout-path. > > Can you unqueue this one until we've figured out what the best fix is ? Done, thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --hU50fLDIZPaBYjJk--