From: Andreas Dannenberg <dannenberg@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings
Date: Mon, 21 Mar 2016 09:06:03 -0500 [thread overview]
Message-ID: <20160321140603.GN20025@borg.dal.design.ti.com> (raw)
In-Reply-To: <20160321124555.GA12693@rob-hp-laptop>
On Mon, Mar 21, 2016 at 07:45:55AM -0500, Rob Herring wrote:
> > +Optional properties:
> > +
> > +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry
> > +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog
> > +- interrupts-extended : reference to a GPIO pin connected to the TAS5720
> > + FAULTZ pin for error reporting purposes
>
> There's no point in having interrupts-extended here with a single
> interrupt. It is fine to use, but really that's outside the scope of
> this binding. So I'd just document "interrupts" here as that is what
> most docs do, and that implies interrupts-extended could be used.
Hi Rob,
Good point. Will remove it for v2.
Regards,
--
Andreas Dannenberg
Texas Instruments Inc
next prev parent reply other threads:[~2016-03-21 14:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 23:27 [PATCH 0/2] ASoC: codecs: add support for TAS5720 digital amplifier Andreas Dannenberg
2016-03-18 23:27 ` [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings Andreas Dannenberg
[not found] ` <1458343678-4086-2-git-send-email-dannenberg-l0cyMroinI0@public.gmane.org>
2016-03-21 12:45 ` Rob Herring
2016-03-21 14:06 ` Andreas Dannenberg [this message]
2016-03-18 23:27 ` [PATCH 2/2] ASoC: codecs: add support for TAS5720 digital amplifier Andreas Dannenberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321140603.GN20025@borg.dal.design.ti.com \
--to=dannenberg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).