From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Dannenberg Subject: Re: [PATCH 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings Date: Mon, 21 Mar 2016 09:06:03 -0500 Message-ID: <20160321140603.GN20025@borg.dal.design.ti.com> References: <1458343678-4086-1-git-send-email-dannenberg@ti.com> <1458343678-4086-2-git-send-email-dannenberg@ti.com> <20160321124555.GA12693@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160321124555.GA12693@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Rob Herring Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Mark Brown , Kumar Gala List-Id: devicetree@vger.kernel.org On Mon, Mar 21, 2016 at 07:45:55AM -0500, Rob Herring wrote: > > +Optional properties: > > + > > +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry > > +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog > > +- interrupts-extended : reference to a GPIO pin connected to the TAS5720 > > + FAULTZ pin for error reporting purposes > > There's no point in having interrupts-extended here with a single > interrupt. It is fine to use, but really that's outside the scope of > this binding. So I'd just document "interrupts" here as that is what > most docs do, and that implies interrupts-extended could be used. Hi Rob, Good point. Will remove it for v2. Regards, -- Andreas Dannenberg Texas Instruments Inc