From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH v3 04/11] ARM: bcm2835: dt: add bindings for shared interrupt properties Date: Tue, 22 Mar 2016 10:24:29 +0000 Message-ID: <20160322102429.GA21158@leverpostej> References: <1457175142-28665-1-git-send-email-kernel@martin.sperl.org> <1457175142-28665-5-git-send-email-kernel@martin.sperl.org> <20160310085714.GA31313@svinekod> <56F10F21.9020709@martin.sperl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <56F10F21.9020709-TqfNSX0MhmxHKSADF0wUEw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Martin Sperl Cc: Rob Herring , Stephen Warren , Lee Jones , Eric Anholt , Vinod Koul , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Mar 22, 2016 at 10:23:45AM +0100, Martin Sperl wrote: > Hi Mark! Hi Martin, Apologies for having gone silent on this. > On 11.03.2016 09:51, Martin Sperl wrote: > >>On 10.03.2016, at 09:57, Mark Rutland wrote: > >> > >>Alternative options that have been considered: > >>* there is unfortunately no =E2=80=9Cinterrupt-names=E2=80=9D prope= rty (like it exists for > >> reg, dma), because then I would have preferred to used: > >> interrupts =3D <...>, <...>, =E2=80=A6; > >> interrupt-name =3D =E2=80=9Cdma0=E2=80=9D, =E2=80=9Cdma1=E2=80= =9D, ..., =E2=80=9Cdma10=E2=80=9D, =E2=80=9Cdmashared=E2=80=9D, =E2=80=9C= dmaall=E2=80=9D; > >> with something like this we could probably have avoided both pro= perties > >> and just added a legacy mapping > >> This would require some changes to the irq framework (which I wa= nted > >> to avoid) >=20 > I have posted a patch based on this approach (after having found out > that it is possible > with the current framework using platform_get_irq_byname). >=20 > Rob Herring has "Acked" the documentation patch: > [PATCH 1/3] dt/bindings: bcm2835: add interrupt-names property >=20 > Is this approach acceptable for you as well, so that we can try to > get it merged? That approach looks good to me too. One minor nit: please explicitly describe the "dma-shared-all" interrupt-name in the description of interrupt-names. Otherwise, for the binding and the code (which I retains support for existing DTs): Acked-by: Mark Rutland Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html