From: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: "Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Kamal Dasu <kdasu.kdev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Frank Rowand
<frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V2 0/4] mtd: nand: add enum nand_ecc_algo
Date: Wed, 23 Mar 2016 11:43:57 +0100 [thread overview]
Message-ID: <20160323114357.377d82fc@bbrezillon> (raw)
In-Reply-To: <1458728343-1234-1-git-send-email-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Wed, 23 Mar 2016 11:18:59 +0100
Rafał Miłecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Some time ago I started working on a new "nand-ecc-algo" property to allow
> specifying ECC algorithm for hardware ECC mode as well.
> Boris pointed out it's becoming a bit messy that way as we already have value
> NAND_ECC_SOFT_BCH.
> I suggested deprecating "soft_bch" value from nand-ecc-mode property and got
> Boris agreed and no objections from others. So there is how I want to implement
> this.
> If you agree on this way & apply my patches, I'll start modifying NAND drivers
> (similarly to the nandsim) and then will try to drop NAND_ECC_SOFT_BCH except
> for handling backward compatibility.
> Then finally we should be able to add "nand-ecc-algo" property support properly.
>
> V2: Add of_get_nand_ecc_algo helper (in 2/4) instead of this slightly hacky code
> in nand_dt_init that would be replaced anyway.
This version looks good to me. If nobody disagree, I'll apply
those patches on my future nand/next branch.
Thanks,
Boris
>
> Rafał Miłecki (4):
> mtd: nand: add new enum for storing ECC algorithm
> of: mtd: prepare helper reading NAND ECC algo from DT
> mtd: nand: set ECC algorithm in nand_dt_init
> mtd: nand: nandsim: set ECC algorithm explicitly
>
> drivers/mtd/nand/nand_base.c | 6 +++++-
> drivers/mtd/nand/nandsim.c | 2 ++
> drivers/of/of_mtd.c | 36 ++++++++++++++++++++++++++++++++++++
> include/linux/mtd/nand.h | 7 +++++++
> include/linux/of_mtd.h | 6 ++++++
> 5 files changed, 56 insertions(+), 1 deletion(-)
>
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-23 10:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 10:18 [PATCH V2 0/4] mtd: nand: add enum nand_ecc_algo Rafał Miłecki
[not found] ` <1458728343-1234-1-git-send-email-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-23 10:19 ` [PATCH V2 1/4] mtd: nand: add new enum for storing ECC algorithm Rafał Miłecki
2016-03-23 10:19 ` [PATCH V2 2/4] of: mtd: prepare helper reading NAND ECC algo from DT Rafał Miłecki
2016-03-23 10:19 ` [PATCH V2 3/4] mtd: nand: set ECC algorithm in nand_dt_init Rafał Miłecki
2016-03-23 10:19 ` [PATCH V2 4/4] mtd: nand: nandsim: set ECC algorithm explicitly Rafał Miłecki
2016-03-23 10:43 ` Boris Brezillon [this message]
2016-03-30 13:27 ` [PATCH V2 0/4] mtd: nand: add enum nand_ecc_algo Boris Brezillon
2016-04-02 7:11 ` Boris Brezillon
2016-03-30 13:58 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323114357.377d82fc@bbrezillon \
--to=boris.brezillon-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=frowand.list-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=kdasu.kdev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).