From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH 4/4] arm64: dts: marvell: Rename armada-ap806 XOR nodes Date: Thu, 24 Mar 2016 09:17:26 +0100 Message-ID: <20160324091726.6eaf83ec@free-electrons.com> References: <1458771861-12392-1-git-send-email-afaerber@suse.de> <1458771861-12392-5-git-send-email-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1458771861-12392-5-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andreas =?UTF-8?B?RsOkcmJlcg==?= Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Jason Cooper , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Catalin Marinas , Will Deacon , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list List-Id: devicetree@vger.kernel.org Hello, On Wed, 23 Mar 2016 23:24:21 +0100, Andreas F=C3=A4rber wrote: > Node names should not contain an instance number, the unit address > serves to distinguish nodes of the same name. So rename the XOR nodes > to just xor@address, using xorX as label instead. >=20 > Fixes: ec7e5a569bce ("arm64: dts: marvell: add Device Tree files for = Armada 7K/8K") > Cc: Thomas Petazzoni > Signed-off-by: Andreas F=C3=A4rber Removing the instance number from the node name is obviously good. However, I don't think it's really needed to add labels. The XOR engines are purely "internal" devices, so they are always enabled at the SoC level. > "marvell,mv-xor-v2" is not yet referenced from any driver in next-20= 160323. Yes. The driver has been submitted, but has received some comments that I need to address. Thanks! Thomas --=20 Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html