devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] ARM: sunxi: dt: Add missing DRAM gate clock for simplefb TV output
@ 2016-03-24 18:08 Priit Laes
  2016-03-24 18:08 ` [PATCH 1/2] ARM: sun4i: dt: Enable dram gate 5 (tve0 clock) " Priit Laes
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Priit Laes @ 2016-03-24 18:08 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Priit Laes

From: Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>

DRAM gating driver commit for sun[47]i seems to be missing DRAM gate bit 5 for
simplefb TV output node. Add it.

Priit Laes (2):
  ARM: sun4i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output
  ARM: sun7i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output

 arch/arm/boot/dts/sun4i-a10.dtsi | 2 +-
 arch/arm/boot/dts/sun7i-a20.dtsi | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

-- 
2.5.0

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] ARM: sun4i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output
  2016-03-24 18:08 [PATCH 0/2] ARM: sunxi: dt: Add missing DRAM gate clock for simplefb TV output Priit Laes
@ 2016-03-24 18:08 ` Priit Laes
       [not found]   ` <1458842920-30854-2-git-send-email-Priit.Laes-FvMSrs6xSY+ptlylMvRsHA@public.gmane.org>
  2016-03-24 18:08 ` [PATCH 2/2] ARM: sun7i: " Priit Laes
       [not found] ` <1458842920-30854-1-git-send-email-Priit.Laes-FvMSrs6xSY+ptlylMvRsHA@public.gmane.org>
  2 siblings, 1 reply; 6+ messages in thread
From: Priit Laes @ 2016-03-24 18:08 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai
  Cc: devicetree, linux-arm-kernel, linux-kernel, Priit Laes

From: Priit Laes <plaes@plaes.org>

Seems like dram_gate 5 was forgotten when DRAM gate driver was added.

Enable it.

Signed-off-by: Priit Laes <plaes@plaes.org>
---
 arch/arm/boot/dts/sun4i-a10.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index 2c8f5e6..bf70d0a 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi
@@ -96,7 +96,7 @@
 			allwinner,pipeline = "de_fe0-de_be0-lcd0-tve0";
 			clocks = <&pll5 1>, <&ahb_gates 34>, <&ahb_gates 36>,
 				 <&ahb_gates 44>, <&ahb_gates 46>,
-				 <&dram_gates 25>, <&dram_gates 26>;
+				 <&dram_gates 5>, <&dram_gates 25>, <&dram_gates 26>;
 			status = "disabled";
 		};
 	};
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: sun7i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output
  2016-03-24 18:08 [PATCH 0/2] ARM: sunxi: dt: Add missing DRAM gate clock for simplefb TV output Priit Laes
  2016-03-24 18:08 ` [PATCH 1/2] ARM: sun4i: dt: Enable dram gate 5 (tve0 clock) " Priit Laes
@ 2016-03-24 18:08 ` Priit Laes
       [not found]   ` <1458842920-30854-3-git-send-email-Priit.Laes-FvMSrs6xSY+ptlylMvRsHA@public.gmane.org>
       [not found] ` <1458842920-30854-1-git-send-email-Priit.Laes-FvMSrs6xSY+ptlylMvRsHA@public.gmane.org>
  2 siblings, 1 reply; 6+ messages in thread
From: Priit Laes @ 2016-03-24 18:08 UTC (permalink / raw)
  To: Maxime Ripard, Chen-Yu Tsai
  Cc: devicetree, linux-arm-kernel, linux-kernel, Priit Laes

From: Priit Laes <plaes@plaes.org>

Seems like dram_gate 5 was forgotten when DRAM gating driver was added.

Enable it.

Signed-off-by: Priit Laes <plaes@plaes.org>
---
 arch/arm/boot/dts/sun7i-a20.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index 0940a78..ee4e8e7 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -85,8 +85,9 @@
 			compatible = "allwinner,simple-framebuffer",
 				     "simple-framebuffer";
 			allwinner,pipeline = "de_be0-lcd0-tve0";
-			clocks = <&pll5 1>, <&ahb_gates 34>, <&ahb_gates 36>,
-				 <&ahb_gates 44>, <&dram_gates 26>;
+			clocks = <&pll5 1>,
+				 <&ahb_gates 34>, <&ahb_gates 36>, <&ahb_gates 44>,
+				 <&dram_gates 5>, <&dram_gates 26>;
 			status = "disabled";
 		};
 	};
-- 
2.5.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] ARM: sunxi: dt: Add missing DRAM gate clock for simplefb TV output
       [not found] ` <1458842920-30854-1-git-send-email-Priit.Laes-FvMSrs6xSY+ptlylMvRsHA@public.gmane.org>
@ 2016-03-24 18:45   ` Maxime Ripard
  0 siblings, 0 replies; 6+ messages in thread
From: Maxime Ripard @ 2016-03-24 18:45 UTC (permalink / raw)
  To: Priit Laes
  Cc: Chen-Yu Tsai, devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Priit Laes

[-- Attachment #1: Type: text/plain, Size: 443 bytes --]

Hi,

On Thu, Mar 24, 2016 at 08:08:38PM +0200, Priit Laes wrote:
> From: Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
> 
> DRAM gating driver commit for sun[47]i seems to be missing DRAM gate bit 5 for
> simplefb TV output node. Add it.

Thanks, could you please add the Fixes tag and Cc stable ?

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: sun4i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output
       [not found]   ` <1458842920-30854-2-git-send-email-Priit.Laes-FvMSrs6xSY+ptlylMvRsHA@public.gmane.org>
@ 2016-03-25  3:03     ` Chen-Yu Tsai
  0 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2016-03-25  3:03 UTC (permalink / raw)
  To: Priit Laes
  Cc: Maxime Ripard, Chen-Yu Tsai, devicetree, linux-arm-kernel,
	linux-kernel, Priit Laes

On Fri, Mar 25, 2016 at 2:08 AM, Priit Laes <Priit.Laes-FvMSrs6xSY+ptlylMvRsHA@public.gmane.org> wrote:
> From: Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
>
> Seems like dram_gate 5 was forgotten when DRAM gate driver was added.
>
> Enable it.
>
> Signed-off-by: Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>

Fixes: 82f8582feef4 ("ARM: dts: sun4i: Add DRAM gates")

Thanks!

> ---
>  arch/arm/boot/dts/sun4i-a10.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> index 2c8f5e6..bf70d0a 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -96,7 +96,7 @@
>                         allwinner,pipeline = "de_fe0-de_be0-lcd0-tve0";
>                         clocks = <&pll5 1>, <&ahb_gates 34>, <&ahb_gates 36>,
>                                  <&ahb_gates 44>, <&ahb_gates 46>,
> -                                <&dram_gates 25>, <&dram_gates 26>;
> +                                <&dram_gates 5>, <&dram_gates 25>, <&dram_gates 26>;
>                         status = "disabled";
>                 };
>         };
> --
> 2.5.0
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] ARM: sun7i: dt: Enable dram gate 5 (tve0 clock) for simplefb TV output
       [not found]   ` <1458842920-30854-3-git-send-email-Priit.Laes-FvMSrs6xSY+ptlylMvRsHA@public.gmane.org>
@ 2016-03-25  3:04     ` Chen-Yu Tsai
  0 siblings, 0 replies; 6+ messages in thread
From: Chen-Yu Tsai @ 2016-03-25  3:04 UTC (permalink / raw)
  To: Priit Laes
  Cc: Maxime Ripard, Chen-Yu Tsai, devicetree, linux-arm-kernel,
	linux-kernel, Priit Laes

On Fri, Mar 25, 2016 at 2:08 AM, Priit Laes <Priit.Laes-FvMSrs6xSY+ptlylMvRsHA@public.gmane.org> wrote:
> From: Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>
>
> Seems like dram_gate 5 was forgotten when DRAM gating driver was added.
>
> Enable it.
>
> Signed-off-by: Priit Laes <plaes-q/aMd4JkU83YtjvyW6yDsg@public.gmane.org>


Fixes: 0b4bf5a5200b ("ARM: dts: sun7i: Add DRAM gates")

Thanks!

> ---
>  arch/arm/boot/dts/sun7i-a20.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 0940a78..ee4e8e7 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -85,8 +85,9 @@
>                         compatible = "allwinner,simple-framebuffer",
>                                      "simple-framebuffer";
>                         allwinner,pipeline = "de_be0-lcd0-tve0";
> -                       clocks = <&pll5 1>, <&ahb_gates 34>, <&ahb_gates 36>,
> -                                <&ahb_gates 44>, <&dram_gates 26>;
> +                       clocks = <&pll5 1>,
> +                                <&ahb_gates 34>, <&ahb_gates 36>, <&ahb_gates 44>,
> +                                <&dram_gates 5>, <&dram_gates 26>;
>                         status = "disabled";
>                 };
>         };
> --
> 2.5.0
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-03-25  3:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-24 18:08 [PATCH 0/2] ARM: sunxi: dt: Add missing DRAM gate clock for simplefb TV output Priit Laes
2016-03-24 18:08 ` [PATCH 1/2] ARM: sun4i: dt: Enable dram gate 5 (tve0 clock) " Priit Laes
     [not found]   ` <1458842920-30854-2-git-send-email-Priit.Laes-FvMSrs6xSY+ptlylMvRsHA@public.gmane.org>
2016-03-25  3:03     ` Chen-Yu Tsai
2016-03-24 18:08 ` [PATCH 2/2] ARM: sun7i: " Priit Laes
     [not found]   ` <1458842920-30854-3-git-send-email-Priit.Laes-FvMSrs6xSY+ptlylMvRsHA@public.gmane.org>
2016-03-25  3:04     ` Chen-Yu Tsai
     [not found] ` <1458842920-30854-1-git-send-email-Priit.Laes-FvMSrs6xSY+ptlylMvRsHA@public.gmane.org>
2016-03-24 18:45   ` [PATCH 0/2] ARM: sunxi: dt: Add missing DRAM gate clock " Maxime Ripard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).