From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v7] rtc: rewrite DS1302 using SPI Date: Mon, 28 Mar 2016 22:57:13 +0200 Message-ID: <20160328205713.GA2346@piout.net> References: <1456105286-28598-1-git-send-email-ynvich@gmail.com> <1456224900-4877-1-git-send-email-ynvich@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1456224900-4877-1-git-send-email-ynvich-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sergei Ianovich Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alessandro Zummo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:REAL TIME CLOCK RTC SUBSYSTEM" List-Id: devicetree@vger.kernel.org On 23/02/2016 at 13:54:57 +0300, Sergei Ianovich wrote : > DS1302 is half-duplex SPI device. The driver respects this fact now. > > Pin configurations should be implemented using SPI subsystem. > > Signed-off-by: Sergei Ianovich > CC: Alexandre Belloni > CC: Rob Herring > > v6..v7 > * change binding and doc file names > > v5..v6 > * rewrite the driver as an SPI slave device > * use "maxim" for vendor name per Kconfig > * stop changing device RAM in device presence test > * only return time from device if valid > * use burst mode for reading/writing time > * dropped charging control. I cannot test it, and it looks broken > > v4..v5 > * drop THIS_MODULE from struct platform driver > * use "dallas" for vendor name per vendor-prefixes.txt > > v3..v4 > * move DTS bindings to a different patch > > v2..v3 > * use usleep_range instead of custom nsleep > * number change (07/16 -> 09/21) > > v0..v2 > * use device tree > * use devm helpers where possible > --- > .../devicetree/bindings/rtc/maxim-ds1302.txt | 46 +++ > drivers/rtc/Kconfig | 15 +- > drivers/rtc/rtc-ds1302.c | 348 ++++++++++----------- > 3 files changed, 212 insertions(+), 197 deletions(-) > create mode 100644 Documentation/devicetree/bindings/rtc/maxim-ds1302.txt > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html