From: Lee Jones <lee.jones@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, maxime.coquelin@st.com,
patrice.chotard@st.com, srinivas.kandagatla@gmail.com,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/4] ARM: STi: DT: STiH407: Add DT node for eeprom
Date: Tue, 29 Mar 2016 10:12:58 +0100 [thread overview]
Message-ID: <20160329091258.GC8659@x1> (raw)
In-Reply-To: <1458920188-29612-5-git-send-email-peter.griffin@linaro.org>
More information is required in the commit message.
What do we use the EEPROM for? What information is contained within?
What stops working if we don't support it? What starts working if we
do?
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
> ---
> arch/arm/boot/dts/stihxxx-b2120.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> index 133375b..0d7c6dd 100644
> --- a/arch/arm/boot/dts/stihxxx-b2120.dtsi
> +++ b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> @@ -58,6 +58,15 @@
>
> i2c@9845000 {
> status = "okay";
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + eeprom@50 {
> + compatible = "at,24c256";
> + pagesize = <64>;
> + reg = <0x50>;
> + };
> };
>
> i2c@9540000 {
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2016-03-29 9:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 15:36 [PATCH 0/4] STi DT updates Peter Griffin
2016-03-25 15:36 ` [PATCH 1/4] ARM: DT: STiH407: Add UART RTS/CTS pin configuration Peter Griffin
2016-03-25 15:36 ` [PATCH 2/4] ARM: DT: STiH407: Add i2c12 pin definition Peter Griffin
2016-03-25 15:36 ` [PATCH 3/4] ARM: DT: STiH407: Add node for i2c12 controller Peter Griffin
2016-03-25 15:36 ` [PATCH 4/4] ARM: STi: DT: STiH407: Add DT node for eeprom Peter Griffin
2016-03-29 9:12 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329091258.GC8659@x1 \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@st.com \
--cc=patrice.chotard@st.com \
--cc=peter.griffin@linaro.org \
--cc=srinivas.kandagatla@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).