From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default Date: Tue, 29 Mar 2016 12:51:28 +0200 Message-ID: <20160329105128.GA30184@amd> References: <1457827580-16919-1-git-send-email-sre@kernel.org> <1457827580-16919-5-git-send-email-sre@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1457827580-16919-5-git-send-email-sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sebastian Reichel Cc: Tony Lindgren , =?iso-8859-1?Q?Beno=EEt?= Cousson , Aaro Koskinen , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi! For 1-3 in the series, Acked-by: Pavel Machek > Like the Nokia N900, the N950 has leds to show > the state of sys_clkreq and sys_off_mode pins. > > A detailed description for the LEDs and > OMAP's sleep states can be found in Tony's > commit for the Nokia N900: > > c1be2032f66df9e1238bd5bc4ca666de88a62abc I must say I've seen it on N900, and yes, it is useful, but no, I don't think this is right. This is not a LED. This is a interface that changes meaning of two other LEDs. I guess it should go to debugfs somewhere. Best regards, Pavel > Signed-off-by: Sebastian Reichel > +++ b/arch/arm/boot/dts/omap3-n950-n9.dtsi > @@ -31,9 +31,27 @@ > startup-delay-us = <150>; > enable-active-high; > }; > + > + leds { > + compatible = "gpio-leds"; > + > + heartbeat { > + label = "debug::sleep"; > + gpios = <&gpio3 28 GPIO_ACTIVE_HIGH>; /* gpio92 */ > + linux,default-trigger = "default-on"; > + pinctrl-names = "default"; > + pinctrl-0 = <&debug_leds>; > + }; > + }; > }; > > &omap3_pmx_core { > + debug_leds: pinmux_debug_led_pins { > + pinctrl-single,pins = < > + OMAP3_CORE1_IOPAD(0x2108, PIN_OUTPUT | MUX_MODE4) /* dss_data22.gpio_92 */ > + >; > + }; > + > mmc2_pins: pinmux_mmc2_pins { > pinctrl-single,pins = < > OMAP3_CORE1_IOPAD(0x2158, PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc2_clk */ -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html