From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH V2 0/4] mtd: nand: add enum nand_ecc_algo Date: Wed, 30 Mar 2016 15:58:10 +0200 Message-ID: <20160330155810.328f2a1e@bbrezillon> References: <1458728343-1234-1-git-send-email-zajec5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1458728343-1234-1-git-send-email-zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Brian Norris , linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kamal Dasu , Rob Herring , Grant Likely , Frank Rowand List-Id: devicetree@vger.kernel.org Hi Rafal, On Wed, 23 Mar 2016 11:18:59 +0100 Rafa=C5=82 Mi=C5=82ecki wrote: > Some time ago I started working on a new "nand-ecc-algo" property to = allow > specifying ECC algorithm for hardware ECC mode as well. > Boris pointed out it's becoming a bit messy that way as we already ha= ve value > NAND_ECC_SOFT_BCH. > I suggested deprecating "soft_bch" value from nand-ecc-mode property = and got > Boris agreed and no objections from others. So there is how I want to= implement > this. > If you agree on this way & apply my patches, I'll start modifying NAN= D drivers > (similarly to the nandsim) and then will try to drop NAND_ECC_SOFT_BC= H except > for handling backward compatibility. > Then finally we should be able to add "nand-ecc-algo" property suppor= t properly. >=20 > V2: Add of_get_nand_ecc_algo helper (in 2/4) instead of this slightly= hacky code > in nand_dt_init that would be replaced anyway. Whole series applied to nand/next [1]. I just added a comment for the ecc->algo field in patch 1. You can continue your rework (patch existing NAND_ECC_SOFT_BCH and NAND_ECC_SOFT users to use ecc->algo). Thanks, Boris [1]https://github.com/linux-nand/linux/tree/nand/next --=20 Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html