From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop Date: Wed, 30 Mar 2016 14:09:16 -0700 Message-ID: <20160330210916.GB21993@roeck-us.net> References: <20151106220249.GA19791@roeck-us.net> <565F4244.7090502@timesys.com> <20151228162923.GA31680@spo001.leaseweb.nl> <56AA79DA.2010305@timesys.com> <56F991C3.8030201@timesys.com> <20160330012226.GD28207@tiger> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160330012226.GD28207@tiger> Sender: linux-watchdog-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Shawn Guo Cc: Akshay Bhat , Fabio Estevam , Rob Herring , Wim Van Sebroeck , Tim Harvey , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Sascha Hauer , Russell King - ARM Linux , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Justin Waters , Lucas Stach , Stefan Roese List-Id: devicetree@vger.kernel.org On Wed, Mar 30, 2016 at 09:22:33AM +0800, Shawn Guo wrote: > On Mon, Mar 28, 2016 at 04:19:15PM -0400, Akshay Bhat wrote: > > Hi Shawn, > > > > On 02/28/2016 08:56 AM, Fabio Estevam wrote: > > >Rob, > > > > > >On Thu, Jan 28, 2016 at 6:28 PM, Akshay Bhat wrote: > > > > > >>>I have no objections against the idea and the code itself. > > >>>But as Guenter pointed out: it would be handy to get feedback from the > > >>>devicetree maintainers on the above discussion. > > >>> > > >>>Kind regards, > > >>>Wim. > > >>> > > >> > > >>Any suggestions on whether a vendor specific prefix is necessary? > > > > > >Any comments? > > > > > > > Is this something you can help with, since you are the iMX > > architecture/devicetree maintainer? Appreciate any feedback. > > FWIW, > > Acked-by: Shawn Guo > > Guenter, > > I think it's reasonable to pick up the patch, if we have it copied to DT > maintainers and on the list for a long period of time, and do not see > any objection from anyone. > The question was if the property name should be ext-reset-output or fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output because it is not a generic property. Tim disagrees. So we have two options: Change the property name to fsl,ext-reset-output, which I would accept, or wait for a devicetree maintainer to make a decision. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html