From: Shawn Guo <shawnguo@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>, Tim Harvey <tharvey@gateworks.com>
Cc: Akshay Bhat <akshay.bhat@timesys.com>,
Fabio Estevam <festevam@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Justin Waters <justin.waters@timesys.com>,
Lucas Stach <l.stach@pengutronix.de>, Stefan Roese <sr@denx.de>
Subject: Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop
Date: Thu, 31 Mar 2016 09:57:14 +0800 [thread overview]
Message-ID: <20160331015714.GM28207@tiger> (raw)
In-Reply-To: <20160330210916.GB21993@roeck-us.net>
On Wed, Mar 30, 2016 at 02:09:16PM -0700, Guenter Roeck wrote:
> The question was if the property name should be ext-reset-output or
> fsl,ext-reset-output. In my opinion, it should be fsl,ext-reset-output
> because it is not a generic property. Tim disagrees.
>
> So we have two options: Change the property name to fsl,ext-reset-output,
> which I would accept, or wait for a devicetree maintainer to make a decision.
Guenter,
I agree with you on this point. Before everyone agrees that this is a
generic binding, we should have vendor prefix for the property.
Tim,
This is a small change which, IMO, shouldn't hold an useful patch from being
merged. Care to resend with the suggested change?
Shawn
next prev parent reply other threads:[~2016-03-31 1:57 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 21:19 [PATCH v4 0/2] imx6: Implement external watchdog reset Akshay Bhat
2015-11-05 21:19 ` [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop Akshay Bhat
[not found] ` <1446758362-11702-2-git-send-email-akshay.bhat-jEh4hwF5bVhBDgjK7y7TUQ@public.gmane.org>
2015-11-05 22:23 ` Guenter Roeck
2015-11-06 19:53 ` Tim Harvey
[not found] ` <CAJ+vNU2fSxRJ7YvxOfNzoEoiKgzv-dHj=+eksKxH48ekHiUw2Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-11-06 22:02 ` Guenter Roeck
[not found] ` <20151106220249.GA19791-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-12-02 19:11 ` Akshay Bhat
[not found] ` <565F4244.7090502-jEh4hwF5bVhBDgjK7y7TUQ@public.gmane.org>
2015-12-02 20:54 ` Tim Harvey
[not found] ` <CAJ+vNU00Bf97HUqkkW9KqOUzHXh482R9O1gasz6ju3Pn-_5chA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-17 15:02 ` Tim Harvey
[not found] ` <CAJ+vNU2qHQPSJ1KWp_3f3vAdeuOcF0ooZHmHsdafabZLXJv=Bw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-17 15:32 ` Guenter Roeck
2015-12-28 16:29 ` Wim Van Sebroeck
[not found] ` <20151228162923.GA31680-1F/o1hAF34+bEvaWgpTR7vP6llvjuJOh@public.gmane.org>
2016-01-28 20:28 ` Akshay Bhat
[not found] ` <56AA79DA.2010305-jEh4hwF5bVhBDgjK7y7TUQ@public.gmane.org>
2016-02-28 13:56 ` Fabio Estevam
[not found] ` <CAOMZO5DrTY3ho0Z_jXxeYMqbd6GmUKRwD1LB61vM1ZTGQAYOrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-28 20:19 ` Akshay Bhat
2016-03-30 1:22 ` Shawn Guo
2016-03-30 21:09 ` Guenter Roeck
2016-03-31 1:57 ` Shawn Guo [this message]
2016-03-31 18:01 ` Tim Harvey
[not found] ` <CAJ+vNU2zBCAF8hJfmSa31CyD9XcOCxYWqH9LKRm1S_sunqkgOg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-01 1:39 ` Shawn Guo
2015-11-05 21:19 ` [PATCH v4 2/2] ARM: dts: ventana: Add ext-reset support Akshay Bhat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331015714.GM28207@tiger \
--to=shawnguo@kernel.org \
--cc=akshay.bhat@timesys.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=justin.waters@timesys.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sr@denx.de \
--cc=tharvey@gateworks.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).