From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: "Lothar Waßmann" <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
Cc: Dan Williams
<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHv2 3/8] ARM: dts: imx6-tx6: remove regulator bus
Date: Thu, 31 Mar 2016 14:00:34 +0800 [thread overview]
Message-ID: <20160331060034.GN28207@tiger> (raw)
In-Reply-To: <1457424244-14549-4-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
On Tue, Mar 08, 2016 at 09:03:59AM +0100, Lothar Waßmann wrote:
> DT maintainers don't like the 'simple-bus' container around the
> regulator nodes. So remove it.
>
> Signed-off-by: Lothar Waßmann <LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
> ---
> arch/arm/boot/dts/imx6qdl-tx6.dtsi | 178 +++++++++++++++++--------------------
> 1 file changed, 81 insertions(+), 97 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-tx6.dtsi b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
> index 912f284..ec374f5 100644
> --- a/arch/arm/boot/dts/imx6qdl-tx6.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-tx6.dtsi
> @@ -97,104 +97,88 @@
> };
> };
>
> - regulators {
> - compatible = "simple-bus";
> - #address-cells = <1>;
> - #size-cells = <0>;
> + reg_3v3_etn: reg-3v3-etn {
Please use the following naming schema for fixed regulators.
reg_xxx: regulator-xxx {
...
}
Shawn
> + compatible = "regulator-fixed";
> + regulator-name = "3V3_ETN";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_etnphy_power>;
> + gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
>
> - reg_3v3_etn: regulator@0 {
> - compatible = "regulator-fixed";
> - reg = <0>;
> - regulator-name = "3V3_ETN";
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> - pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_etnphy_power>;
> - gpio = <&gpio3 20 GPIO_ACTIVE_HIGH>;
> - enable-active-high;
> - };
> -
> - reg_2v5: regulator@1 {
> - compatible = "regulator-fixed";
> - reg = <1>;
> - regulator-name = "2V5";
> - regulator-min-microvolt = <2500000>;
> - regulator-max-microvolt = <2500000>;
> - regulator-always-on;
> - };
> -
> - reg_3v3: regulator@2 {
> - compatible = "regulator-fixed";
> - reg = <2>;
> - regulator-name = "3V3";
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> - regulator-always-on;
> - };
> -
> - reg_can_xcvr: regulator@3 {
> - compatible = "regulator-fixed";
> - reg = <3>;
> - regulator-name = "CAN XCVR";
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> - pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_flexcan_xcvr>;
> - gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
> - enable-active-low;
> - };
> -
> - reg_lcd0_pwr: regulator@4 {
> - compatible = "regulator-fixed";
> - reg = <4>;
> - regulator-name = "LCD0 POWER";
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> - pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_lcd0_pwr>;
> - gpio = <&gpio3 29 GPIO_ACTIVE_HIGH>;
> - enable-active-high;
> - regulator-boot-on;
> - regulator-always-on;
> - };
> -
> - reg_lcd1_pwr: regulator@5 {
> - compatible = "regulator-fixed";
> - reg = <5>;
> - regulator-name = "LCD1 POWER";
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> - pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_lcd1_pwr>;
> - gpio = <&gpio2 31 GPIO_ACTIVE_HIGH>;
> - enable-active-high;
> - regulator-boot-on;
> - regulator-always-on;
> - };
> -
> - reg_usbh1_vbus: regulator@6 {
> - compatible = "regulator-fixed";
> - reg = <6>;
> - regulator-name = "usbh1_vbus";
> - regulator-min-microvolt = <5000000>;
> - regulator-max-microvolt = <5000000>;
> - pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_usbh1_vbus>;
> - gpio = <&gpio3 31 GPIO_ACTIVE_HIGH>;
> - enable-active-high;
> - };
> -
> - reg_usbotg_vbus: regulator@7 {
> - compatible = "regulator-fixed";
> - reg = <7>;
> - regulator-name = "usbotg_vbus";
> - regulator-min-microvolt = <5000000>;
> - regulator-max-microvolt = <5000000>;
> - pinctrl-names = "default";
> - pinctrl-0 = <&pinctrl_usbotg_vbus>;
> - gpio = <&gpio1 7 GPIO_ACTIVE_HIGH>;
> - enable-active-high;
> - };
> + reg_2v5: reg-2v5 {
> + compatible = "regulator-fixed";
> + regulator-name = "2V5";
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <2500000>;
> + regulator-always-on;
> + };
> +
> + reg_3v3: reg-3v3 {
> + compatible = "regulator-fixed";
> + regulator-name = "3V3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
> + reg_can_xcvr: reg-can-xcvr {
> + compatible = "regulator-fixed";
> + regulator-name = "CAN XCVR";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_flexcan_xcvr>;
> + gpio = <&gpio4 21 GPIO_ACTIVE_HIGH>;
> + enable-active-low;
> + };
> +
> + reg_lcd0_pwr: reg-lcd0-pwr {
> + compatible = "regulator-fixed";
> + regulator-name = "LCD0 POWER";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_lcd0_pwr>;
> + gpio = <&gpio3 29 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + regulator-boot-on;
> + };
> +
> + reg_lcd1_pwr: reg-lcd1-pwr {
> + compatible = "regulator-fixed";
> + regulator-name = "LCD1 POWER";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_lcd1_pwr>;
> + gpio = <&gpio2 31 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + regulator-boot-on;
> + };
> +
> + reg_usbh1_vbus: reg-usbh1-vbus {
> + compatible = "regulator-fixed";
> + regulator-name = "usbh1_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usbh1_vbus>;
> + gpio = <&gpio3 31 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> + };
> +
> + reg_usbotg_vbus: reg-usbotg-vbus {
> + compatible = "regulator-fixed";
> + regulator-name = "usbotg_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usbotg_vbus>;
> + gpio = <&gpio1 7 GPIO_ACTIVE_HIGH>;
> + enable-active-high;
> };
>
> sound {
> --
> 2.1.4
>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-31 6:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 8:03 [PATCHv2 0/8] ARM: dts: update Ka-Ro i.MX6 module support Lothar Waßmann
[not found] ` <1457424244-14549-1-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
2016-03-08 8:03 ` [PATCHv2 1/8] ARM: dts: imx6-tx6: Relicense the Ka-Ro DT files under GPLv2/X11 Lothar Waßmann
2016-03-08 8:03 ` [PATCHv2 2/8] ARM: dts: imx6-tx6: cleanup; no functional change Lothar Waßmann
2016-03-08 8:03 ` [PATCHv2 3/8] ARM: dts: imx6-tx6: remove regulator bus Lothar Waßmann
[not found] ` <1457424244-14549-4-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
2016-03-31 6:00 ` Shawn Guo [this message]
2016-03-08 8:04 ` [PATCHv2 7/8] ARM: dts: imx6: add support for more Ka-Ro electronics modules Lothar Waßmann
2016-03-31 6:10 ` Shawn Guo
2016-03-31 6:29 ` Lothar Waßmann
2016-03-31 7:47 ` Shawn Guo
2016-03-08 8:04 ` [PATCHv2 8/8] ARM: dts: imx6: add support for the Ka-Ro electronics 'MB7' baseboard Lothar Waßmann
2016-03-31 6:14 ` [PATCHv2 0/8] ARM: dts: update Ka-Ro i.MX6 module support Shawn Guo
2016-03-08 8:04 ` [PATCHv2 4/8] ARM: dts: imx6-tx6: disable the spi node by default Lothar Waßmann
2016-03-08 8:04 ` [PATCHv2 5/8] ARM: dts: imx6-tx6: remove container node around pinctrl nodes Lothar Waßmann
2016-03-08 8:04 ` [PATCHv2 6/8] ARM: dts: imx6qdl-tx6: add mdio node for ethernet phy Lothar Waßmann
2016-03-31 12:33 ` [PATCHv3 0/5] ARM: dts: update Ka-Ro i.MX6 module support Lothar Waßmann
2016-03-31 12:33 ` [PATCHv3 1/5] ARM: dts: imx6-tx6: remove regulator bus Lothar Waßmann
2016-03-31 12:33 ` [PATCHv3 2/5] ARM: dts: imx6-tx6: remove LED pinctrl setting from hoggrp Lothar Waßmann
2016-03-31 12:33 ` [PATCHv3 3/5] ARM: dts: imx6-tx6: enable support for rtscts on UARTs Lothar Waßmann
2016-03-31 12:33 ` [PATCHv3 5/5] ARM: dts: imx6: add support for the Ka-Ro electronics 'MB7' baseboard Lothar Waßmann
[not found] ` <1459427625-15568-1-git-send-email-LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org>
2016-03-31 12:33 ` [PATCHv3 4/5] ARM: dts: imx6: add support for more Ka-Ro electronics modules Lothar Waßmann
2016-04-11 13:57 ` [PATCHv3 0/5] ARM: dts: update Ka-Ro i.MX6 module support Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160331060034.GN28207@tiger \
--to=shawnguo-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=LW-bxm8fMRDkQLDiMYJYoSAnRvVK+yQ3ZXh@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).