From: Pavel Machek <pavel@ucw.cz>
To: Tony Lindgren <tony@atomide.com>
Cc: "Sebastian Reichel" <sre@kernel.org>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Kumar Gala" <galak@codeaurora.org>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default
Date: Sat, 2 Apr 2016 08:47:57 +0200 [thread overview]
Message-ID: <20160402064757.GA13872@amd> (raw)
In-Reply-To: <20160401183221.GN9329@atomide.com>
Hi!
> > > The two LEDs this GPIO controls are hardwired to sys_clkreq and
> > > sys_off_mode pins that are the control signals between the SoC
> > > and PMIC.
> >
> > No, not on N900. On N900, these LEDs are normally used for keyboard
> > backlight.
>
> Oh I see. I've totally forgotten that as I always keep the debug
> option enabled :) The extra battery consumption by those is quite
> minimal and warns you if you have something hogging the CPU.
Yes, I like it.
> > ...and this is what this GPIO does. So it is not exactly a LED. You
> > can turn it on, but than, _two_ LEDs will start blinking. You can't
> > control them with the brightess control. "Heartbeat" trigger is going
> > to be very confusing on debug::sleep.
>
> And it occured to me that adding any other policy than
> "default-on" to the GPIO LED will only work when the device
> is active.
>
> Sounds like the thing to do is to just configure the I2C LED
> controller in the dts file if we don't already have that. And
> assuming it has a Linux driver.
I don't see what you mean here. If you want to always keep the debug
leds on... that may be a bit confusing for the users (and Pali wants
to keep kernel usable for mere mortals it seems).
Anyway, current solution is not too horrible (its wrong but it does
not hurt that much), so...
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2016-04-02 6:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-13 0:06 [PATCH 0/7] Nokia N9/N950 misc. DT patches Sebastian Reichel
2016-03-13 0:06 ` [PATCH 1/7] ARM: dts: n9/n950: regulator configuration Sebastian Reichel
2016-03-13 0:06 ` [PATCH 2/7] ARM: dts: OMAP3-N950: Add Keypad Matrix Sebastian Reichel
2016-03-13 0:06 ` [PATCH 3/7] ARM: dts: OMAP3-N950: Add Vibrator Sebastian Reichel
2016-03-13 0:06 ` [PATCH 4/7] ARM: dts: Enable N950 keyboard sleep leds by default Sebastian Reichel
[not found] ` <1457827580-16919-5-git-send-email-sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-03-29 10:51 ` Pavel Machek
2016-03-29 14:52 ` Sebastian Reichel
2016-03-29 17:54 ` Pavel Machek
2016-03-30 19:35 ` Tony Lindgren
2016-03-31 0:48 ` Sebastian Reichel
2016-04-01 12:45 ` Pavel Machek
2016-04-01 18:32 ` Tony Lindgren
2016-04-02 6:47 ` Pavel Machek [this message]
2016-04-12 21:02 ` Tony Lindgren
[not found] ` <1457827580-16919-1-git-send-email-sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2016-03-13 0:06 ` Sebastian Reichel
2016-03-13 0:06 ` [PATCH 5/7] ARM: dts: OMAP3-N950: Add Keypad Slide Switch Sebastian Reichel
2016-03-13 0:06 ` [PATCH 6/7] ARM: dts: N9/N950: Add support for 1GHz CPU clock Sebastian Reichel
2016-03-13 0:06 ` [PATCH 7/7] ARM: dts: N9/N950: Add support for accelerometer Sebastian Reichel
2016-03-29 10:53 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160402064757.GA13872@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).