From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH] clk: sunxi: Add CSI (camera's Sensors Interface) module clock driver for sun[457]i Date: Mon, 4 Apr 2016 14:24:50 -0700 Message-ID: <20160404212450.GP4227@lukather> References: <1458204222-31149-1-git-send-email-yassinjaffer@gmail.com> <1458204222-31149-2-git-send-email-yassinjaffer@gmail.com> <20160319235905.GA16539@rob-hp-laptop> <20160402011436.GA18567@codeaurora.org> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="l3ej7W/Jb2pB3qL2" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20160402011436.GA18567-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Stephen Boyd Cc: Rob Herring , yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dev-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Chen-Yu Tsai , Emilio =?iso-8859-1?Q?L=F3pez?= , Michael Turquette , Hans de Goede , Reinder de Haan , Jens Kuske , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/Allwinner sunXi SoC support" , open list , "open list:COMMON CLK FRAMEWORK" List-Id: devicetree@vger.kernel.org --l3ej7W/Jb2pB3qL2 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Hi Stephen On Fri, Apr 01, 2016 at 06:14:36PM -0700, Stephen Boyd wrote: > On 03/19, Rob Herring wrote: > > On Thu, Mar 17, 2016 at 07:43:42PM +1100, yassinjaffer-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > > > From: Yassin Jaffer > > > > > > This patch adds a composite clock type consisting of > > > a clock gate, mux, configurable dividers, and a reset control. > > > > > > Signed-off-by: Yassin Jaffer > > > --- > > > Documentation/devicetree/bindings/clock/sunxi.txt | 1 + > > > > I wish someone would just add all the sunxi clocks in one pass instead > > of one by one. > > > > Acked-by: Rob Herring > > Me too! I understand, but it's probably not going to happen. The clock tree is massive, and obviously you have to multiply that by the number of SoCs we have. And to be honest, I don't really see the point of merging clock drivers that have never been tested, and might be massively broken, especially now that we have this ABI requirement for the DT, and we can't adjust the binding when we actually start using that clock. Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --l3ej7W/Jb2pB3qL2--