From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
linux-mtd@lists.infradead.org, Kamal Dasu <kdasu.kdev@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
David Woodhouse <dwmw2@infradead.org>,
Simon Arlott <simon@fire.lp0.eu>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:BROADCOM STB NAND FLASH DRIVER"
<bcm-kernel-feedback-list@broadcom.com>,
Richard Weinberger <richard@nod.at>
Subject: Re: [PATCH] mtd: brcmnand: Add support for v6.2 controllers
Date: Mon, 4 Apr 2016 23:48:53 +0200 [thread overview]
Message-ID: <20160404234853.2a3d58a1@bbrezillon> (raw)
In-Reply-To: <20160404065353.GE13995@localhost>
On Sun, 3 Apr 2016 23:53:53 -0700
Brian Norris <computersforpeace@gmail.com> wrote:
> + Boris, Richard
>
> On Thu, Mar 10, 2016 at 03:34:16PM -0800, Florian Fainelli wrote:
> > Document and match the brcm,brcmnand-v6.2 compatible string, the controller has
> > a register layout identical to the v6.0 version and supports prefetch. Update the
> > command shift logic to account for v6.2 controller which are the first ones to
> > use a shift of 0 (6.1 used a shift of 24).
>
> Ah yes, another blip in the ever-shifting register layout of this
> controller. Fun!
>
> > Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
>
> Acked-by: Brian Norris <computersforpeace@gmail.com>
Applied.
Thanks,
Boris
>
> > ---
> > Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt | 1 +
> > drivers/mtd/nand/brcmnand/brcmnand.c | 3 ++-
> > 2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> > index c2546ced9c02..deb24cbdda82 100644
> > --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> > +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.txt
> > @@ -24,6 +24,7 @@ Required properties:
> > brcm,brcmnand-v5.0
> > brcm,brcmnand-v6.0
> > brcm,brcmnand-v6.1
> > + brcm,brcmnand-v6.2
> > brcm,brcmnand-v7.0
> > brcm,brcmnand-v7.1
> > brcm,brcmnand
> > diff --git a/drivers/mtd/nand/brcmnand/brcmnand.c b/drivers/mtd/nand/brcmnand/brcmnand.c
> > index e0528397306a..0b7a698cc233 100644
> > --- a/drivers/mtd/nand/brcmnand/brcmnand.c
> > +++ b/drivers/mtd/nand/brcmnand/brcmnand.c
> > @@ -601,7 +601,7 @@ static void brcmnand_wr_corr_thresh(struct brcmnand_host *host, u8 val)
> >
> > static inline int brcmnand_cmd_shift(struct brcmnand_controller *ctrl)
> > {
> > - if (ctrl->nand_version < 0x0700)
> > + if (ctrl->nand_version < 0x0602)
> > return 24;
> > return 0;
> > }
> > @@ -2115,6 +2115,7 @@ static const struct of_device_id brcmnand_of_match[] = {
> > { .compatible = "brcm,brcmnand-v5.0" },
> > { .compatible = "brcm,brcmnand-v6.0" },
> > { .compatible = "brcm,brcmnand-v6.1" },
> > + { .compatible = "brcm,brcmnand-v6.2" },
> > { .compatible = "brcm,brcmnand-v7.0" },
> > { .compatible = "brcm,brcmnand-v7.1" },
> > {},
> > --
> > 2.1.0
> >
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
prev parent reply other threads:[~2016-04-04 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 23:34 [PATCH] mtd: brcmnand: Add support for v6.2 controllers Florian Fainelli
[not found] ` <1457652859-767-1-git-send-email-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-18 16:40 ` Rob Herring
2016-04-04 6:53 ` Brian Norris
2016-04-04 21:48 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160404234853.2a3d58a1@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kdasu.kdev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).