From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH v2 2/3] ARM: imx6: rework GPC to support multiple power domains Date: Thu, 7 Apr 2016 10:48:57 +0800 Message-ID: <20160407024857.GA3111@x250> References: <1458128514-9560-1-git-send-email-l.stach@pengutronix.de> <1458128514-9560-2-git-send-email-l.stach@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1458128514-9560-2-git-send-email-l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lucas Stach Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, patchwork-lst-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Mar 16, 2016 at 12:41:53PM +0100, Lucas Stach wrote: > This largely reworks the GPC driver to better accommodate multiple > power domains. This allows to extend the driver to support more domains > (like present on i.MX6SX) easily later on. > > Compatibility to the old DT bindings is provided to keep the currently > supported i.MX6 devices working with the same feature level as before. > New DTs and SoC support should only use the new binding from now on. > > Signed-off-by: Lucas Stach > --- > v2: correct spelling in commit message > --- > arch/arm/mach-imx/gpc.c | 435 ++++++++++++++++++++++++++++++++++++------------ > 1 file changed, 329 insertions(+), 106 deletions(-) There are too many changes in this single patch. It makes the review quite difficult. Is it possible to split it a bit into some incremental patches? Also please rebase against v4.6-rc1, which has the commit eaa2d73ef998 (ARM: imx6: pm: declare pm domain latency on power_state struct) conflicting with your changes. Shawn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html