From: Rob Herring <robh@kernel.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lina Iyer <lina.iyer@linaro.org>,
Axel Haslam <ahaslam@baylibre.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Jon Hunter <jonathanh@nvidia.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] PM / Domains: Define DT bindings for PM QoS device latencies
Date: Thu, 7 Apr 2016 12:57:04 -0500 [thread overview]
Message-ID: <20160407175704.GA32257@rob-hp-laptop> (raw)
In-Reply-To: <CAPDyKFombK0Kv-r40xbTm=Y3q07bM5woOPB63xzbrck37Vxrqw@mail.gmail.com>
On Mon, Apr 04, 2016 at 11:42:04AM +0200, Ulf Hansson wrote:
> On 1 April 2016 at 20:44, Rob Herring <robh@kernel.org> wrote:
> > On Thu, Mar 31, 2016 at 03:50:25PM +0200, Ulf Hansson wrote:
> >> PM QoS device latencies are properties of the hardware. Let's define some
> >> DT bindings for them.
> >>
> >> Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> >> ---
> >> Documentation/devicetree/bindings/power/power_domain.txt | 6 ++++++
> >> 1 file changed, 6 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/power/power_domain.txt b/Documentation/devicetree/bindings/power/power_domain.txt
> >> index 025b5e7..b101a20 100644
> >> --- a/Documentation/devicetree/bindings/power/power_domain.txt
> >> +++ b/Documentation/devicetree/bindings/power/power_domain.txt
> >> @@ -65,12 +65,18 @@ Required properties:
> >> - power-domains : A phandle and PM domain specifier as defined by bindings of
> >> the power controller specified by phandle.
> >>
> >> +Optional properties:
> >> + - suspend-latency: Suspend latency of the device in ns.
> >> + - resume-latency: Resume latency of the device in ns.
> >
> > The names are a bit Linux specific, but I don't have a better
> > suggestion. Could be power-up/down, but then you may have other
> > latencies such as link up times.
> >
> > Whatever we end up with, add a unit suffix (-ns).
>
> Okay.
>
> >
> > Shouldn't this be split into latency of the domain (and in the domain's
> > node) and latency of the device?
>
> Yes! $Subject patch only takes device latencies into account.
>
> Perhaps what you mean is that we should document device PM QoS
> latencies in another place than
> Documentation/devicetree/bindings/power/power_domain.txt as well?
Yes, the location is confusing that this is device latency which has
nothing to do with power domains other than the fact we've lost all
state (which a reset could cause too).
> Regarding bindings for the domain latencies, I will post that as a
> separate patch soonish.
It probably makes sense to look at latency bindings as a whole series.
Rob
next prev parent reply other threads:[~2016-04-07 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 13:50 [PATCH 1/2] PM / Domains: Define DT bindings for PM QoS device latencies Ulf Hansson
2016-03-31 13:50 ` [PATCH 2/2] PM / Domains: Retrieve PM QoS device latencies from DT Ulf Hansson
2016-04-01 18:44 ` [PATCH 1/2] PM / Domains: Define DT bindings for PM QoS device latencies Rob Herring
2016-04-04 9:42 ` Ulf Hansson
2016-04-07 17:57 ` Rob Herring [this message]
2016-04-08 11:19 ` Ulf Hansson
2016-04-11 13:29 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407175704.GA32257@rob-hp-laptop \
--to=robh@kernel.org \
--cc=ahaslam@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jonathanh@nvidia.com \
--cc=khilman@kernel.org \
--cc=len.brown@intel.com \
--cc=lina.iyer@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox