From: Rob Herring <robh@kernel.org>
To: Joao Pinto <Joao.Pinto@synopsys.com>
Cc: tomas.winkler@intel.com, vinholikatti@gmail.com,
julian.calaby@gmail.com, akinobu.mita@gmail.com,
hch@infradead.org, gbroner@codeaurora.org,
subhashj@codeaurora.org, CARLOS.PALMINHA@synopsys.com,
ijc+devicetree@hellion.org.uk, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, devicetree@vger.kernel.org,
arnd@arndb.de, mark.rutland@arm.com
Subject: Re: [PATCH v12 8/9] add TC G210 platform driver
Date: Thu, 7 Apr 2016 12:57:08 -0500 [thread overview]
Message-ID: <20160407175708.GB32257@rob-hp-laptop> (raw)
In-Reply-To: <57024677.2060009@synopsys.com>
On Mon, Apr 04, 2016 at 11:48:23AM +0100, Joao Pinto wrote:
>
> Hi Rob,
>
> On 4/4/2016 6:15 AM, Rob Herring wrote:
> > On Thu, Mar 31, 2016 at 07:57:21PM +0100, Joao Pinto wrote:
> >> This patch adds a glue platform driver for the Synopsys G210 Test Chip.
> >>
> >> Signed-off-by: Joao Pinto <jpinto@synopsys.com>
> >> ---
>
> [snip]
>
> >> +
> >> +Required properties:
> >> +- compatible : compatible list must contain the PHY type & version:
> >> + "snps, g210-tc-6.00-20bit"
> >> + "snps, g210-tc-6.00-40bit"
> > Remove the space ^
> >
> >> + complemented with the Controller IP version:
> >> + "snps, dwc-ufshcd-1.40a"
> >
> > ditto
>
> Ok, will do that!
>
> >
> > Combining the phy and controller compatible strings is a bit strange.
> > Generally, they would be separate nodes using the common phy binding.
> >
>
> Correct, but in this case is just the compatibility string is just to tell the
> dw ufs host that it has a 40-bit or a 20-bit test chip connected. The Test chip
> is initialized by a unipro command sequence and there is no more ops related to it.
Okay. In that case, I think it should be a separate property unless the
controller h/w is synthesized for one or the other.
Rob
next prev parent reply other threads:[~2016-04-07 17:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 18:57 [PATCH v12 0/9] add support for DWC UFS Controller Joao Pinto
2016-03-31 18:57 ` [PATCH v12 1/9] fixed typo in ufshcd-pltfrm Joao Pinto
2016-03-31 18:57 ` [PATCH v12 2/9] add UFS 2.0 to ufshcd-pltfrm bindings Joao Pinto
2016-04-04 5:15 ` Rob Herring
2016-03-31 18:57 ` [PATCH v12 3/9] added UFS 2.0 capabilities Joao Pinto
2016-03-31 20:27 ` Winkler, Tomas
2016-04-01 9:19 ` Joao Pinto
2016-03-31 18:57 ` [PATCH v12 4/9] added unipro attributes Joao Pinto
[not found] ` <cover.1459448160.git.jpinto-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2016-03-31 18:57 ` [PATCH v12 5/9] added link status to ufshci Joao Pinto
2016-03-31 18:57 ` [PATCH v12 6/9] added support for DesignWare Controller Joao Pinto
2016-03-31 18:57 ` [PATCH v12 7/9] added support for Synopsys G210 Test Chip Joao Pinto
2016-03-31 18:57 ` [PATCH v12 8/9] add TC G210 platform driver Joao Pinto
2016-04-04 5:15 ` Rob Herring
2016-04-04 10:48 ` Joao Pinto
2016-04-07 17:57 ` Rob Herring [this message]
2016-04-08 9:13 ` Joao Pinto
2016-03-31 18:57 ` [PATCH v12 9/9] add TC G210 pci driver Joao Pinto
2016-04-04 23:34 ` [PATCH v13 0/9] add support for DWC UFS Controller Martin K. Petersen
2016-04-05 9:09 ` Joao Pinto
2016-04-05 10:15 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B541E3FE8-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-04-05 10:27 ` Joao Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160407175708.GB32257@rob-hp-laptop \
--to=robh@kernel.org \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=akinobu.mita@gmail.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gbroner@codeaurora.org \
--cc=hch@infradead.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=julian.calaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=subhashj@codeaurora.org \
--cc=tomas.winkler@intel.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox