From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 3/5] dmaengine: qcom: bam_dma: add controlled remotely dt property Date: Thu, 7 Apr 2016 12:57:52 -0500 Message-ID: <20160407175752.GM32257@rob-hp-laptop> References: <1459896982-30171-1-git-send-email-stanimir.varbanov@linaro.org> <1459896982-30171-4-git-send-email-stanimir.varbanov@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1459896982-30171-4-git-send-email-stanimir.varbanov@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Stanimir Varbanov Cc: Mark Rutland , devicetree@vger.kernel.org, Vinod Koul , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Sinan Kaya , dmaengine@vger.kernel.org, Andy Gross , Pramod Gurav , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Wed, Apr 06, 2016 at 01:56:20AM +0300, Stanimir Varbanov wrote: > Some of the peripherals has bam which is controlled by remote > processor, thus the bam dma driver must avoid register writes > which initialise bam hw block. Those registers are protected > from xPU block and any writes to them will lead to secure > violation and system reboot. > > Adding the contolled_remotely flag in bam driver to avoid > not permitted register writes in bam_init function. > > Signed-off-by: Stanimir Varbanov > Reviewed-by: Andy Gross > --- > Documentation/devicetree/bindings/dma/qcom_bam_dma.txt | 2 ++ > drivers/dma/qcom/bam_dma.c | 7 +++++++ > 2 files changed, 9 insertions(+) Acked-by: Rob Herring On being a separate patch, yes that is always the preference. However, this change is so small it doesn't matter to me. But this is going in thru Vinod's tree, so it is his call. Rob