From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH 1/4] rtc: ds1302: fix error check in set_time Date: Sun, 10 Apr 2016 17:17:33 +0200 Message-ID: <20160410151733.GE5377@piout.net> References: <1460300366-25248-1-git-send-email-akinobu.mita@gmail.com> <1460300366-25248-2-git-send-email-akinobu.mita@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1460300366-25248-2-git-send-email-akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Akinobu Mita Cc: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Sergey Yanovich , Alessandro Zummo List-Id: devicetree@vger.kernel.org On 10/04/2016 at 23:59:23 +0900, Akinobu Mita wrote : > The set_time callback for rtc-ds1302 doesn't write clock registers > because the error check for the return value from spi_write_then_read() > is not correct. spi_write_then_read() which returns zero on success. > > Signed-off-by: Akinobu Mita > Cc: Sergey Yanovich > Cc: Alessandro Zummo > Cc: Alexandre Belloni > --- > drivers/rtc/rtc-ds1302.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html