From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v5 2/2] auxdisplay: ht16k33: Driver for LED controller Date: Mon, 11 Apr 2016 09:49:56 -0500 Message-ID: <20160411144956.GA26808@rob-hp-laptop> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Robin van der Gracht Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Miguel Ojeda Sandonis , Thierry Reding , Jonathan Cameron , Mark Brown , Maxime Ripard , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Apr 07, 2016 at 10:54:01AM +0200, Robin van der Gracht wrote: > Added a driver for the Holtek HT16K33 LED controller with keyscan. > > Signed-off-by: Robin van der Gracht > --- > Changes in v5: > - Updated compatible string > - the HT16K33_FB_SIZE define now uses BYTES_PER_ROW as multiplier instead of 2 > - Dropped a trailing '\' in ht16k33.txt > - Shortened commit message (exceeded 80 chars in v4) > > .../devicetree/bindings/display/ht16k33.txt | 42 ++ > drivers/auxdisplay/Kconfig | 9 + > drivers/auxdisplay/Makefile | 1 + > drivers/auxdisplay/ht16k33.c | 563 +++++++++++++++++++++ > 4 files changed, 615 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/ht16k33.txt > create mode 100644 drivers/auxdisplay/ht16k33.c > > diff --git a/Documentation/devicetree/bindings/display/ht16k33.txt b/Documentation/devicetree/bindings/display/ht16k33.txt > new file mode 100644 > index 0000000..d9694b7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/ht16k33.txt > @@ -0,0 +1,42 @@ > +Holtek ht16k33 RAM mapping 16*8 LED controller driver with keyscan > +------------------------------------------------------------------------------- > + > +Required properties: > +- compatible: "holtek,ht16k33" > +- reg: I2C slave address of the chip. > +- interrupt-parent: A phandle pointing to the interrupt controller > + serving the interrupt for this chip. > +- interrupts: Interrupt specification for the key pressed interrupt. > +- refresh-rate-hz: Display update interval in HZ. > +- debounce-delay-ms: Debouncing interval time in microseconds. '-ms' is milliseconds, but you have usec... ^^^^^^^^^^^^ Otherwise, Acked-by: Rob Herring -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html