From: Tony Lindgren <tony@atomide.com>
To: "Franklin S Cooper Jr." <fcooper@ti.com>
Cc: Rob Herring <robh@kernel.org>,
thierry.reding@gmail.com, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, bcousson@baylibre.com,
linux@arm.linux.org.uk, paul@pwsan.com,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, vigneshr@ti.com
Subject: Re: [PATCH v5 6/6] ARM: dts: DRA7: Add dt nodes for PWMSS
Date: Mon, 11 Apr 2016 13:21:12 -0700 [thread overview]
Message-ID: <20160411202112.GE5995@atomide.com> (raw)
In-Reply-To: <56EAD315.1030307@ti.com>
* Franklin S Cooper Jr. <fcooper@ti.com> [160317 08:55]:
>
>
> On 03/17/2016 10:11 AM, Rob Herring wrote:
> > On Mon, Mar 07, 2016 at 07:23:44PM -0600, Franklin S Cooper Jr wrote:
> >> From: Vignesh R <vigneshr@ti.com>
> >>
> >> Add PWMSS device tree nodes for DRA7 SoC family and add documentation
> >> for dt bindings.
> >>
> >> Signed-off-by: Vignesh R <vigneshr@ti.com>
> >> [fcooper@ti.com: Add eCAP and use updated bindings for PWMSS and ePWM]
> >> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> >> ---
> >> Version 5 changes:
> >> Add DT node for eCAP and update eCAP binding documentation
> >>
> >> Version 4 changes:
> >> Updated link to the latest documentation
> >>
> >> .../devicetree/bindings/pwm/pwm-tiecap.txt | 9 +++
> >> .../devicetree/bindings/pwm/pwm-tiehrpwm.txt | 9 +++
> >> .../devicetree/bindings/pwm/pwm-tipwmss.txt | 15 +++-
> >> arch/arm/boot/dts/dra7.dtsi | 84 ++++++++++++++++++++++
> >> 4 files changed, 116 insertions(+), 1 deletion(-)
> >
> >> + ehrpwm1: pwm@48440200 {
> >> + compatible = "ti,dra7xx-ehrpwm",
> >> + "ti,am33xx-ehrpwm";
> >> + #pwm-cells = <3>;
> >> + reg = <0x48440200 0x80>;
> >> + clocks = <&ehrpwm1_tbclk>;
> >> + clock-names = "tbclk";
> >> + status = "disabled";
> >> + };
> >> +
> >> + ecap1: ecap@48440100 {
> > This also is a PWM? Then it should also be pwm@...
>
> The enhanced capture module primary purpose is to measure
> time between external signals which is called capture mode.
> It also has a PWM mode. So I wouldn't recommend generalizing
> the entire node to pwm.
So is this patch safe for me to apply now or do we need more
changes?
Regards,
Tony
next prev parent reply other threads:[~2016-04-11 20:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 1:23 [PATCH v5 0/6] ARM: am335x/am437x/dra7: Add PWM support for DRA7 Franklin S Cooper Jr
2016-03-08 1:23 ` [PATCH v5 1/6] pwms: pwm-ti*: Get the clock from the PWMSS (parent) Franklin S Cooper Jr
2016-03-17 22:37 ` Franklin S Cooper Jr.
2016-04-05 6:08 ` Sekhar Nori
2016-04-05 11:25 ` Franklin S Cooper Jr.
[not found] ` <5703A0C4.6010406-l0cyMroinI0@public.gmane.org>
2016-04-10 20:51 ` Paul Walmsley
[not found] ` <alpine.DEB.2.02.1604102048380.11457-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2016-04-11 11:49 ` Sekhar Nori
2016-04-11 12:45 ` Rob Herring
2016-04-12 8:10 ` Sekhar Nori
[not found] ` <1457400224-24797-1-git-send-email-fcooper-l0cyMroinI0@public.gmane.org>
2016-03-08 1:23 ` [PATCH v5 2/6] ARM: dts: am437x/am33xx: Remove eCAP and ePWM hwmod properties Franklin S Cooper Jr
2016-03-08 6:55 ` [PATCH v5 0/6] ARM: am335x/am437x/dra7: Add PWM support for DRA7 Paul Walmsley
2016-03-08 17:04 ` Franklin S Cooper Jr.
2016-03-08 1:23 ` [PATCH v5 3/6] ARM: AM335x/AM437x: hwmod: Remove eQEP, ePWM and eCAP hwmod entries Franklin S Cooper Jr
[not found] ` <1457400224-24797-4-git-send-email-fcooper-l0cyMroinI0@public.gmane.org>
2016-03-17 15:06 ` Rob Herring
2016-03-17 15:45 ` Franklin S Cooper Jr.
2016-03-17 19:04 ` Rob Herring
2016-03-08 1:23 ` [PATCH v5 4/6] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Franklin S Cooper Jr
2016-03-08 6:45 ` Paul Walmsley
2016-04-10 18:57 ` Paul Walmsley
2016-03-08 1:23 ` [PATCH v5 5/6] ARM: dts: DRA7: Add TBCLK " Franklin S Cooper Jr
2016-04-11 20:21 ` Tony Lindgren
2016-04-11 20:27 ` Tony Lindgren
2016-03-08 1:23 ` [PATCH v5 6/6] ARM: dts: DRA7: Add dt nodes " Franklin S Cooper Jr
[not found] ` <1457400224-24797-7-git-send-email-fcooper-l0cyMroinI0@public.gmane.org>
2016-03-17 15:11 ` Rob Herring
2016-03-17 15:53 ` Franklin S Cooper Jr.
2016-04-11 20:21 ` Tony Lindgren [this message]
2016-04-19 16:20 ` Franklin S Cooper Jr.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411202112.GE5995@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=fcooper@ti.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=paul@pwsan.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).