From: Shawn Guo <shawnguo@kernel.org>
To: Stefan Agner <stefan@agner.ch>
Cc: jianwei.wang.chn@gmail.com, meng.yi@nxp.com, pawel.moll@arm.com,
alison.wang@freescale.com, daniel.vetter@ffwll.ch,
mturquette@baylibre.com, ijc+devicetree@hellion.org.uk,
sboyd@codeaurora.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, kernel@pengutronix.de, galak@codeaurora.org,
mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
alexander.stein@systec-electronic.com
Subject: Re: [PATCH v3 1/9] ARM: imx: clk-vf610: fix DCU clock tree
Date: Tue, 12 Apr 2016 09:38:21 +0800 [thread overview]
Message-ID: <20160412013820.GC15949@tiger> (raw)
In-Reply-To: <1459834121-25997-2-git-send-email-stefan@agner.ch>
On Mon, Apr 04, 2016 at 10:28:33PM -0700, Stefan Agner wrote:
> Similar to an earlier fix for the SAI clocks, the DCU clock hierarchy
> mixes the bus clock with the display controllers pixel clock. Tests
> have shown that the gates in CCM_CCGR3/9 registers do not control
> the DCU pixel clock, but only the register access clock (bus clock).
>
> Fix this by defining the parent clock of VF610_CLK_DCUx to be the bus
> clock (ipg_bus).
>
> Since the clock has not been used far, there are no further changes
> needed.
>
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Applied 1 and 2, with updating subject prefix to be 'clk: imx: vf610: '
Shawn
> ---
> drivers/clk/imx/clk-vf610.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/imx/clk-vf610.c b/drivers/clk/imx/clk-vf610.c
> index 0a94d96..426fde2 100644
> --- a/drivers/clk/imx/clk-vf610.c
> +++ b/drivers/clk/imx/clk-vf610.c
> @@ -321,11 +321,11 @@ static void __init vf610_clocks_init(struct device_node *ccm_node)
> clk[VF610_CLK_DCU0_SEL] = imx_clk_mux("dcu0_sel", CCM_CSCMR1, 28, 1, dcu_sels, 2);
> clk[VF610_CLK_DCU0_EN] = imx_clk_gate("dcu0_en", "dcu0_sel", CCM_CSCDR3, 19);
> clk[VF610_CLK_DCU0_DIV] = imx_clk_divider("dcu0_div", "dcu0_en", CCM_CSCDR3, 16, 3);
> - clk[VF610_CLK_DCU0] = imx_clk_gate2("dcu0", "dcu0_div", CCM_CCGR3, CCM_CCGRx_CGn(8));
> + clk[VF610_CLK_DCU0] = imx_clk_gate2("dcu0", "ipg_bus", CCM_CCGR3, CCM_CCGRx_CGn(8));
> clk[VF610_CLK_DCU1_SEL] = imx_clk_mux("dcu1_sel", CCM_CSCMR1, 29, 1, dcu_sels, 2);
> clk[VF610_CLK_DCU1_EN] = imx_clk_gate("dcu1_en", "dcu1_sel", CCM_CSCDR3, 23);
> clk[VF610_CLK_DCU1_DIV] = imx_clk_divider("dcu1_div", "dcu1_en", CCM_CSCDR3, 20, 3);
> - clk[VF610_CLK_DCU1] = imx_clk_gate2("dcu1", "dcu1_div", CCM_CCGR9, CCM_CCGRx_CGn(8));
> + clk[VF610_CLK_DCU1] = imx_clk_gate2("dcu1", "ipg_bus", CCM_CCGR9, CCM_CCGRx_CGn(8));
>
> clk[VF610_CLK_ESAI_SEL] = imx_clk_mux("esai_sel", CCM_CSCMR1, 20, 2, esai_sels, 4);
> clk[VF610_CLK_ESAI_EN] = imx_clk_gate("esai_en", "esai_sel", CCM_CSCDR2, 30);
> --
> 2.7.4
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-04-12 1:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 5:28 [PATCH v3 0/9] add TCON and Vybrid support Stefan Agner
2016-04-05 5:28 ` [PATCH v3 1/9] ARM: imx: clk-vf610: fix DCU clock tree Stefan Agner
2016-04-12 1:38 ` Shawn Guo [this message]
2016-04-13 5:21 ` Stefan Agner
2016-04-16 0:31 ` Stephen Boyd
2016-04-05 5:28 ` [PATCH v3 2/9] ARM: imx: clk-vf610: add TCON ipg clock Stefan Agner
2016-04-05 5:28 ` [PATCH v3 3/9] drm/fsl-dcu: disable clock on initialization failure and remove Stefan Agner
2016-04-05 5:28 ` [PATCH v3 4/9] drm/fsl-dcu: add extra clock for pixel clock Stefan Agner
2016-04-07 17:57 ` Rob Herring
2016-04-05 5:28 ` [PATCH v3 5/9] drm/fsl-dcu: use common clock framework for pixel clock divider Stefan Agner
2016-04-05 5:28 ` [PATCH v3 6/9] drm/fsl-dcu: add TCON driver Stefan Agner
2016-04-05 5:28 ` [PATCH v3 7/9] ARM: dts: vf610: add display nodes Stefan Agner
2016-04-13 6:13 ` Shawn Guo
2016-04-05 5:28 ` [PATCH v3 8/9] ARM: dts: vf610-colibri: enable display controller Stefan Agner
2016-04-05 5:28 ` [PATCH v3 9/9] ARM: dts: ls1021a: add pix clock to DCU dts node Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412013820.GC15949@tiger \
--to=shawnguo@kernel.org \
--cc=alexander.stein@systec-electronic.com \
--cc=alison.wang@freescale.com \
--cc=daniel.vetter@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jianwei.wang.chn@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=meng.yi@nxp.com \
--cc=mturquette@baylibre.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).