* [PATCH 2/2] arm64: dts: ls2080a: fsl-mc dt node updates
@ 2016-04-01 20:54 Stuart Yoder
[not found] ` <1459544080-28598-1-git-send-email-stuart.yoder-3arQi8VN3Tc@public.gmane.org>
0 siblings, 1 reply; 5+ messages in thread
From: Stuart Yoder @ 2016-04-01 20:54 UTC (permalink / raw)
To: devicetree, linux-arm-kernel
Cc: mark.rutland, german.rivera, linux-kernel, Stuart Yoder, robh+dt,
leoyang.li
From: Stuart Yoder <stuart.yoder@nxp.com>
updates to the fsl-mc node for full functionality:
-msi-parent is needed for interrupt support
-ranges is needed to enable the bus driver to translate bus addresses
-dpmac nodes provide a basis for relating dpmac objects to PHYs
Signed-off-by: Stuart Yoder <stuart.yoder@nxp.com>
---
arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 87 ++++++++++++++++++++++++
1 file changed, 87 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
index 9d746c6..449c635 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
@@ -265,6 +265,93 @@
compatible = "fsl,qoriq-mc";
reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */
<0x00000000 0x08340000 0 0x40000>; /* MC control reg */
+ msi-parent = <&its>;
+ #address-cells = <3>;
+ #size-cells = <1>;
+
+ /*
+ * Region type 0x0 - MC portals
+ * Region type 0x1 - QBMAN portals
+ */
+ ranges = <0x0 0x0 0x0 0x8 0x0c000000 0x4000000
+ 0x1 0x0 0x0 0x8 0x18000000 0x8000000>;
+
+ /*
+ * Define the maximum number of MACs present on the SoC.
+ * They won't necessarily be all probed, since the
+ * Data Path Layout file and the MC firmware can put
+ * fewer actual DPMAC objects on the MC bus.
+ */
+ dpmacs {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ dpmac1: dpmac@1 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <1>;
+ };
+ dpmac2: dpmac@2 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <2>;
+ };
+ dpmac3: dpmac@3 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <3>;
+ };
+ dpmac4: dpmac@4 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <4>;
+ };
+ dpmac5: dpmac@5 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <5>;
+ };
+ dpmac6: dpmac@6 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <6>;
+ };
+ dpmac7: dpmac@7 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <7>;
+ };
+ dpmac8: dpmac@8 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <8>;
+ };
+ dpmac9: dpmac@9 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <9>;
+ };
+ dpmac10: dpmac@10 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <0xa>;
+ };
+ dpmac11: dpmac@11 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <0xb>;
+ };
+ dpmac12: dpmac@12 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <0xc>;
+ };
+ dpmac13: dpmac@13 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <0xd>;
+ };
+ dpmac14: dpmac@14 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <0xe>;
+ };
+ dpmac15: dpmac@15 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <0xf>;
+ };
+ dpmac16: dpmac@16 {
+ compatible = "fsl,qoriq-mc-dpmac";
+ reg = <0x10>;
+ };
+ };
+
};
smmu: iommu@5000000 {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] arm64: dts: ls2080a: fsl-mc dt node updates
[not found] ` <1459544080-28598-1-git-send-email-stuart.yoder-3arQi8VN3Tc@public.gmane.org>
@ 2016-04-13 5:50 ` Shawn Guo
2016-04-13 20:39 ` Stuart Yoder
0 siblings, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2016-04-13 5:50 UTC (permalink / raw)
To: Stuart Yoder
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
mark.rutland-5wv7dgnIgG8, german.rivera-KZfg59tc24xl57MIdRCFDg,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A, leoyang.li-3arQi8VN3Tc
On Fri, Apr 01, 2016 at 03:54:40PM -0500, Stuart Yoder wrote:
> From: Stuart Yoder <stuart.yoder-3arQi8VN3Tc@public.gmane.org>
>
> updates to the fsl-mc node for full functionality:
> -msi-parent is needed for interrupt support
> -ranges is needed to enable the bus driver to translate bus addresses
> -dpmac nodes provide a basis for relating dpmac objects to PHYs
>
> Signed-off-by: Stuart Yoder <stuart.yoder-3arQi8VN3Tc@public.gmane.org>
> ---
> arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 87 ++++++++++++++++++++++++
> 1 file changed, 87 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> index 9d746c6..449c635 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> @@ -265,6 +265,93 @@
> compatible = "fsl,qoriq-mc";
> reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */
> <0x00000000 0x08340000 0 0x40000>; /* MC control reg */
> + msi-parent = <&its>;
> + #address-cells = <3>;
> + #size-cells = <1>;
> +
> + /*
> + * Region type 0x0 - MC portals
> + * Region type 0x1 - QBMAN portals
> + */
> + ranges = <0x0 0x0 0x0 0x8 0x0c000000 0x4000000
> + 0x1 0x0 0x0 0x8 0x18000000 0x8000000>;
> +
> + /*
> + * Define the maximum number of MACs present on the SoC.
> + * They won't necessarily be all probed, since the
> + * Data Path Layout file and the MC firmware can put
> + * fewer actual DPMAC objects on the MC bus.
> + */
> + dpmacs {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + dpmac1: dpmac@1 {
> + compatible = "fsl,qoriq-mc-dpmac";
I did not see how this compatible is used by kernel driver.
> + reg = <1>;
> + };
Please have a newline between nodes.
Shawn
> + dpmac2: dpmac@2 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <2>;
> + };
> + dpmac3: dpmac@3 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <3>;
> + };
> + dpmac4: dpmac@4 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <4>;
> + };
> + dpmac5: dpmac@5 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <5>;
> + };
> + dpmac6: dpmac@6 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <6>;
> + };
> + dpmac7: dpmac@7 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <7>;
> + };
> + dpmac8: dpmac@8 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <8>;
> + };
> + dpmac9: dpmac@9 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <9>;
> + };
> + dpmac10: dpmac@10 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <0xa>;
> + };
> + dpmac11: dpmac@11 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <0xb>;
> + };
> + dpmac12: dpmac@12 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <0xc>;
> + };
> + dpmac13: dpmac@13 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <0xd>;
> + };
> + dpmac14: dpmac@14 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <0xe>;
> + };
> + dpmac15: dpmac@15 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <0xf>;
> + };
> + dpmac16: dpmac@16 {
> + compatible = "fsl,qoriq-mc-dpmac";
> + reg = <0x10>;
> + };
> + };
> +
> };
>
> smmu: iommu@5000000 {
> --
> 1.7.9.5
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 2/2] arm64: dts: ls2080a: fsl-mc dt node updates
2016-04-13 5:50 ` Shawn Guo
@ 2016-04-13 20:39 ` Stuart Yoder
2016-04-18 2:02 ` Shawn Guo
0 siblings, 1 reply; 5+ messages in thread
From: Stuart Yoder @ 2016-04-13 20:39 UTC (permalink / raw)
To: Shawn Guo
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
german.rivera-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Yang-Leo Li
> -----Original Message-----
> From: Shawn Guo [mailto:shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org]
> Sent: Wednesday, April 13, 2016 12:50 AM
> To: Stuart Yoder <stuart.yoder-3arQi8VN3Tc@public.gmane.org>
> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; mark.rutland-5wv7dgnIgG8@public.gmane.org;
> german.rivera-KZfg59tc24xl57MIdRCFDg@public.gmane.org; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; Yang-Leo Li
> <leoyang.li-3arQi8VN3Tc@public.gmane.org>
> Subject: Re: [PATCH 2/2] arm64: dts: ls2080a: fsl-mc dt node updates
>
> On Fri, Apr 01, 2016 at 03:54:40PM -0500, Stuart Yoder wrote:
> > From: Stuart Yoder <stuart.yoder-3arQi8VN3Tc@public.gmane.org>
> >
> > updates to the fsl-mc node for full functionality:
> > -msi-parent is needed for interrupt support
> > -ranges is needed to enable the bus driver to translate bus addresses
> > -dpmac nodes provide a basis for relating dpmac objects to PHYs
> >
> > Signed-off-by: Stuart Yoder <stuart.yoder-3arQi8VN3Tc@public.gmane.org>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi | 87 ++++++++++++++++++++++++
> > 1 file changed, 87 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi b/arch/arm64/boot/dts/freescale/fsl-
> ls2080a.dtsi
> > index 9d746c6..449c635 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls2080a.dtsi
> > @@ -265,6 +265,93 @@
> > compatible = "fsl,qoriq-mc";
> > reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */
> > <0x00000000 0x08340000 0 0x40000>; /* MC control reg */
> > + msi-parent = <&its>;
> > + #address-cells = <3>;
> > + #size-cells = <1>;
> > +
> > + /*
> > + * Region type 0x0 - MC portals
> > + * Region type 0x1 - QBMAN portals
> > + */
> > + ranges = <0x0 0x0 0x0 0x8 0x0c000000 0x4000000
> > + 0x1 0x0 0x0 0x8 0x18000000 0x8000000>;
> > +
> > + /*
> > + * Define the maximum number of MACs present on the SoC.
> > + * They won't necessarily be all probed, since the
> > + * Data Path Layout file and the MC firmware can put
> > + * fewer actual DPMAC objects on the MC bus.
> > + */
> > + dpmacs {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + dpmac1: dpmac@1 {
> > + compatible = "fsl,qoriq-mc-dpmac";
>
> I did not see how this compatible is used by kernel driver.
There is no driver yet, but it will be coming soon. But, does
it matter? Device trees should be describing hardware
without regards to some specific kernel use of a node or
property.
> > + reg = <1>;
> > + };
>
> Please have a newline between nodes.
Ok, will do.
Stuart
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] arm64: dts: ls2080a: fsl-mc dt node updates
2016-04-13 20:39 ` Stuart Yoder
@ 2016-04-18 2:02 ` Shawn Guo
2016-04-18 2:30 ` Shawn Guo
0 siblings, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2016-04-18 2:02 UTC (permalink / raw)
To: Stuart Yoder
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
german.rivera@freescale.com, linux-kernel@vger.kernel.org,
Yang-Leo Li, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org
On Wed, Apr 13, 2016 at 08:39:32PM +0000, Stuart Yoder wrote:
> > > @@ -265,6 +265,93 @@
> > > compatible = "fsl,qoriq-mc";
> > > reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */
> > > <0x00000000 0x08340000 0 0x40000>; /* MC control reg */
> > > + msi-parent = <&its>;
> > > + #address-cells = <3>;
> > > + #size-cells = <1>;
> > > +
> > > + /*
> > > + * Region type 0x0 - MC portals
> > > + * Region type 0x1 - QBMAN portals
> > > + */
> > > + ranges = <0x0 0x0 0x0 0x8 0x0c000000 0x4000000
> > > + 0x1 0x0 0x0 0x8 0x18000000 0x8000000>;
> > > +
> > > + /*
> > > + * Define the maximum number of MACs present on the SoC.
> > > + * They won't necessarily be all probed, since the
> > > + * Data Path Layout file and the MC firmware can put
> > > + * fewer actual DPMAC objects on the MC bus.
> > > + */
> > > + dpmacs {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > +
> > > + dpmac1: dpmac@1 {
> > > + compatible = "fsl,qoriq-mc-dpmac";
> >
> > I did not see how this compatible is used by kernel driver.
>
> There is no driver yet, but it will be coming soon. But, does
> it matter? Device trees should be describing hardware
> without regards to some specific kernel use of a node or
> property.
We need to at least have the bindings documented before we can accept it
in dts files.
Shawn
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] arm64: dts: ls2080a: fsl-mc dt node updates
2016-04-18 2:02 ` Shawn Guo
@ 2016-04-18 2:30 ` Shawn Guo
0 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2016-04-18 2:30 UTC (permalink / raw)
To: Stuart Yoder
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
german.rivera@freescale.com, linux-kernel@vger.kernel.org,
Yang-Leo Li, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org
On Mon, Apr 18, 2016 at 10:02 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Wed, Apr 13, 2016 at 08:39:32PM +0000, Stuart Yoder wrote:
>> > > @@ -265,6 +265,93 @@
>> > > compatible = "fsl,qoriq-mc";
>> > > reg = <0x00000008 0x0c000000 0 0x40>, /* MC portal base */
>> > > <0x00000000 0x08340000 0 0x40000>; /* MC control reg */
>> > > + msi-parent = <&its>;
>> > > + #address-cells = <3>;
>> > > + #size-cells = <1>;
>> > > +
>> > > + /*
>> > > + * Region type 0x0 - MC portals
>> > > + * Region type 0x1 - QBMAN portals
>> > > + */
>> > > + ranges = <0x0 0x0 0x0 0x8 0x0c000000 0x4000000
>> > > + 0x1 0x0 0x0 0x8 0x18000000 0x8000000>;
>> > > +
>> > > + /*
>> > > + * Define the maximum number of MACs present on the SoC.
>> > > + * They won't necessarily be all probed, since the
>> > > + * Data Path Layout file and the MC firmware can put
>> > > + * fewer actual DPMAC objects on the MC bus.
>> > > + */
>> > > + dpmacs {
>> > > + #address-cells = <1>;
>> > > + #size-cells = <0>;
>> > > +
>> > > + dpmac1: dpmac@1 {
>> > > + compatible = "fsl,qoriq-mc-dpmac";
>> >
>> > I did not see how this compatible is used by kernel driver.
>>
>> There is no driver yet, but it will be coming soon. But, does
>> it matter? Device trees should be describing hardware
>> without regards to some specific kernel use of a node or
>> property.
>
> We need to at least have the bindings documented before we can accept it
> in dts files.
Ah, sorry. Missed that the bindings are added by patch 1/2.
Shawn
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-04-18 2:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-01 20:54 [PATCH 2/2] arm64: dts: ls2080a: fsl-mc dt node updates Stuart Yoder
[not found] ` <1459544080-28598-1-git-send-email-stuart.yoder-3arQi8VN3Tc@public.gmane.org>
2016-04-13 5:50 ` Shawn Guo
2016-04-13 20:39 ` Stuart Yoder
2016-04-18 2:02 ` Shawn Guo
2016-04-18 2:30 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).