From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gavin Shan Subject: Re: [PATCH v8 00/45] powerpc/powernv: PCI hotplug support Date: Thu, 14 Apr 2016 15:25:56 +1000 Message-ID: <20160414052556.GA7402@gwshan> References: <1455680668-23298-1-git-send-email-gwshan@linux.vnet.ibm.com> <570DF50F.6010805@ozlabs.ru> <20160413074236.GA28853@gwshan> <570E0E13.6080409@ozlabs.ru> <20160413234246.GA5330@gwshan> <570F0DFB.9090509@ozlabs.ru> Reply-To: Gavin Shan Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <570F0DFB.9090509@ozlabs.ru> Sender: linux-pci-owner@vger.kernel.org To: Alexey Kardashevskiy Cc: Gavin Shan , linuxppc-dev@lists.ozlabs.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, benh@kernel.crashing.org, mpe@ellerman.id.au, dja@axtens.net, bhelgaas@google.com, robherring2@gmail.com, grant.likely@linaro.org List-Id: devicetree@vger.kernel.org On Thu, Apr 14, 2016 at 01:26:51PM +1000, Alexey Kardashevskiy wrote: .../... >> >>Do you mean physically pull the adapter out and insert the same >>adapter back? What's the point for the test case? > > >Because this is what the patchset is for - to replace a physical device on a >physical machine. Powering on/off the slots via sysfs is just an >approximation (which is fine when you are debugging), something can go wrong >and require some work but you do not know it for sure. > Yes, It's absolutely worthy to be covered by the test cases though case (2) covers part of that. Anyway, I'll test it through in next revision. Thanks for your review. > > >-- >Alexey >