From: Rob Herring <robh@kernel.org>
To: tthayer@opensource.altera.com
Cc: bp@alien8.de, dougthompson@xmission.com, m.chehab@samsung.com,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux@arm.linux.org.uk, dinguyen@opensource.altera.com,
grant.likely@linaro.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, tthayer.linux@gmail.com
Subject: Re: [PATCH] Add EDAC peripheral init functions & Ethernet EDAC.
Date: Thu, 14 Apr 2016 09:35:01 -0500 [thread overview]
Message-ID: <20160414143501.GA25212@rob-hp-laptop> (raw)
In-Reply-To: <1460499181-23080-1-git-send-email-tthayer@opensource.altera.com>
On Tue, Apr 12, 2016 at 05:12:55PM -0500, tthayer@opensource.altera.com wrote:
> This patch set adds the memory initialization functions for Altera's
> Arria10 peripherals, the first of which is the Ethernet EDAC. The
> first 3 patches add the memory initialization functionality. The
> last 3 patches add Ethernet EDAC support.
The ethernet part seems a bit strange to me to put under EDAC as EDAC
is primarily memory controller ECC (and caches to some extent). Also you
would not halt the system in case of an UC, but rather just drop the
frame. This would need to be part of the ethernet driver in that case.
Of course, given that ethernet frames already have a CRC, ECC of the
FIFO seems a bit redundant.
Rob
next prev parent reply other threads:[~2016-04-14 14:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-12 22:12 [PATCH] Add EDAC peripheral init functions & Ethernet EDAC tthayer
2016-04-12 22:12 ` [PATCH 1/6] EDAC, altera: Check parent status for Arria10 EDAC block tthayer
2016-04-12 22:12 ` [PATCH 2/6] EDAC, altera: Move IRQ function declaration tthayer
2016-04-12 22:12 ` [PATCH 3/6] EDAC, altera: Add Arria10 ECC memory init functions tthayer
2016-04-12 22:12 ` [PATCH 4/6] Documentation: dt: socfpga: Add Arria10 Ethernet binding tthayer
2016-04-12 22:13 ` [PATCH 5/6] EDAC, altera: Add Arria10 Ethernet EDAC support tthayer
2016-04-12 22:13 ` [PATCH 6/6] ARM: dts: Add Arria10 Ethernet EDAC devicetree entry tthayer
2016-04-14 14:35 ` Rob Herring [this message]
2016-04-15 9:40 ` [PATCH] Add EDAC peripheral init functions & Ethernet EDAC Mauro Carvalho Chehab
2016-04-15 15:27 ` Thor Thayer
2016-04-15 21:46 ` Borislav Petkov
2016-04-18 14:27 ` Thor Thayer
2016-04-18 20:02 ` Borislav Petkov
2016-04-18 20:06 ` Borislav Petkov
2016-04-18 20:25 ` Thor Thayer
2016-04-18 20:15 ` Thor Thayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414143501.GA25212@rob-hp-laptop \
--to=robh@kernel.org \
--cc=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=dougthompson@xmission.com \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.chehab@samsung.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=tthayer.linux@gmail.com \
--cc=tthayer@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox