From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH 3/4] dt-bindings: Update iProc GPIO bindings Date: Thu, 14 Apr 2016 09:38:12 -0500 Message-ID: <20160414143812.GA20964@rob-hp-laptop> References: <1460506523-6249-1-git-send-email-ray.jui@broadcom.com> <1460506523-6249-4-git-send-email-ray.jui@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1460506523-6249-4-git-send-email-ray.jui@broadcom.com> Sender: linux-kernel-owner@vger.kernel.org To: Ray Jui Cc: Linus Walleij , Alexandre Courbot , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On Tue, Apr 12, 2016 at 05:15:22PM -0700, Ray Jui wrote: > Update the iProc GPIO binding document to introduce a new compatible > string "brcm,iproc-gpio-only", that allows the generic pinconf function > to be disabled completely > > Signed-off-by: Ray Jui > Reviewed-by: Jon Mason > Reviewed-by: Scott Branden > --- > Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt b/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt > index ddaa1b0..75a4370 100644 > --- a/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt > +++ b/Documentation/devicetree/bindings/pinctrl/brcm,iproc-gpio.txt > @@ -3,8 +3,11 @@ Broadcom iProc GPIO/PINCONF Controller > Required properties: > > - compatible: > - Must be "brcm,cygnus-ccm-gpio", "brcm,cygnus-asiu-gpio", > - "brcm,cygnus-crmu-gpio" or "brcm,iproc-gpio" > + For Cygnus, it must be brcm,cygnus-ccm-gpio", "brcm,cygnus-asiu-gpio", or > +"brcm,cygnus-crmu-gpio" > + For non-Cygnus iProc SoCs, it must be either "brcm,iproc-gpio-only" (if > +only GPIO is supported) or "brcm,iproc-gpio" (if both generic pinconf and GPIO > +are supported) No. That's not how compatible strings work. Use SoC specific compatible strings if you need to distinguish this. Rob