From: Rob Herring <robh@kernel.org>
To: Timur Tabi <timur@codeaurora.org>
Cc: kbuild test robot <lkp@intel.com>,
kbuild-all@01.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, sdharia@codeaurora.org,
Shanker Donthineni <shankerd@codeaurora.org>,
Greg Kroah-Hartman <greg@kroah.com>,
vikrams@codeaurora.org, cov@codeaurora.org,
gavidov@codeaurora.org, andrew@lunn.ch,
bjorn.andersson@linaro.org, Mark Langsdorf <mlangsdo@redhat.com>,
Jon Masters <jcm@redhat.com>, Andy Gross <agross@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver
Date: Thu, 14 Apr 2016 11:24:07 -0500 [thread overview]
Message-ID: <20160414162407.GA15303@rob-hp-laptop> (raw)
In-Reply-To: <570E9E8D.50007@codeaurora.org>
On Wed, Apr 13, 2016 at 02:31:25PM -0500, Timur Tabi wrote:
> kbuild test robot wrote:
> >
> > drivers/net/ethernet/qualcomm/emac/emac-mac.c: In function 'emac_mac_up':
> >>>>>drivers/net/ethernet/qualcomm/emac/emac-mac.c:1076:9: warning: large integer implicitly truncated to unsigned type [-Woverflow]
> > writel(~DIS_INT, adpt->base + EMAC_INT_STATUS);
>
> This doesn't happen on arm64, and I don't know how to fix it. DIS_INT is
> defined as:
Probably depends on the compiler version. BTW, clang seems to throw
errors for this type of thing.
>
> #define DIS_INT BIT(31)
>
> It seems silly to add a typecast to DIS_INT.
BIT() should use 1U instead of 1.
Rob
next prev parent reply other threads:[~2016-04-14 16:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 17:59 [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver Timur Tabi
2016-04-13 17:59 ` [PATCH 2/2] MAINTAINERS: add Qualcomm EMAC network driver maintainer Timur Tabi
2016-04-13 19:22 ` [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver kbuild test robot
2016-04-13 19:31 ` Timur Tabi
2016-04-13 19:40 ` Shanker Donthineni
2016-04-13 19:55 ` Timur Tabi
2016-04-13 20:07 ` Bjørn Mork
2016-04-14 16:24 ` Rob Herring [this message]
2016-04-13 22:16 ` Florian Fainelli
2016-04-14 20:19 ` Timur Tabi
2016-04-14 21:19 ` Florian Fainelli
2016-04-14 22:00 ` Vikram Sethi
2016-04-14 23:34 ` Timur Tabi
2016-04-15 12:35 ` Rob Herring
2016-04-15 15:44 ` Timur Tabi
2016-04-15 15:59 ` Rob Herring
2016-04-15 17:23 ` Timur Tabi
[not found] ` <57102920.7000104-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-15 16:44 ` Bjorn Andersson
2016-04-15 17:00 ` Timur Tabi
2016-04-15 17:35 ` Bjorn Andersson
2016-04-15 18:22 ` Timur Tabi
2016-04-21 18:03 ` Timur Tabi
2016-04-22 19:45 ` Timur Tabi
2016-04-22 19:56 ` Florian Fainelli
2016-05-10 23:18 ` Timur Tabi
2016-05-10 23:26 ` Florian Fainelli
2016-05-11 2:24 ` Timur Tabi
2016-05-11 20:27 ` Timur Tabi
2016-04-25 13:16 ` Andrew Lunn
2016-06-01 22:27 ` Timur Tabi
[not found] ` <1460570393-19838-1-git-send-email-timur-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-04-14 3:27 ` kbuild test robot
2016-04-14 16:32 ` Rob Herring
2016-04-14 16:47 ` Timur Tabi
2016-04-14 17:18 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160414162407.GA15303@rob-hp-laptop \
--to=robh@kernel.org \
--cc=agross@codeaurora.org \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=cov@codeaurora.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gavidov@codeaurora.org \
--cc=greg@kroah.com \
--cc=jcm@redhat.com \
--cc=kbuild-all@01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mlangsdo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sdharia@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=timur@codeaurora.org \
--cc=vikrams@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox