From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vinod Koul Subject: Re: [PATCH V2 2/3] dmaengine: bcm2835: use platform_get_irq_byname Date: Wed, 20 Apr 2016 18:41:46 +0530 Message-ID: <20160420131146.GA2274@localhost> References: <1460381349-14408-1-git-send-email-kernel@martin.sperl.org> <1460381349-14408-3-git-send-email-kernel@martin.sperl.org> <571762A7.7000005@martin.sperl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Geert Uytterhoeven Cc: Martin Sperl , Rob Herring , Mark Rutland , Stephen Warren , Lee Jones , Eric Anholt , Russell King , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Apr 20, 2016 at 01:12:36PM +0200, Geert Uytterhoeven wrote: > Hi Martin, > > On Wed, Apr 20, 2016 at 1:06 PM, Martin Sperl wrote: > > On 20.04.2016 08:51, Geert Uytterhoeven wrote: > >> > >> On Mon, Apr 11, 2016 at 3:29 PM, wrote: > >>> > >>> From: Martin Sperl > >>> > >>> Use platform_get_irq_byname to allow for correct mapping of > >>> interrupts to dma channels. > >>> > >>> The currently implemented device tree is unfortunately > >>> implemented with the wrong assumption, that each dma-channel > >>> has its own dma channel, but dma-irq 11 is handling > >>> dma-channel 11-14 and dma-irq 12 is actually a "catch all" > >>> interrupt. > >>> > >>> So here we use the byname variant and require that interrupts > >>> are explicitly named via the interrupts-name property in the > >> > >> interrupt-names well spotted > > > > Vinod has just merged this patch - do you want me to submit another > > Yeah, that's how I noticed by accident :-) > > > to correct those? > > For the commit message it's indeed too late. For the error message in the > code, yes please. I can drop the branch -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html