From: Simon Horman <horms@verge.net.au>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: magnus.damm@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, devicetree@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] arm64: defconfig: Add Renesas R-Car USB 3.0 driver support
Date: Thu, 21 Apr 2016 13:15:14 +1000 [thread overview]
Message-ID: <20160421031514.GB11116@verge.net.au> (raw)
In-Reply-To: <1461142034-5008-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>
Hi Shimoda-san,
On Wed, Apr 20, 2016 at 05:47:14PM +0900, Yoshihiro Shimoda wrote:
> If we doesn't enable this configuration and runs on R-Car Gen3,
> xhci host driver will cause timeout in xhci_reset() because
> the R-Car Gen3 xHCI controller needs specific initialization.
>
> [ 1.565605] xhci-hcd ee000000.usb: xHCI Host Controller
> [ 1.570636] xhci-hcd ee000000.usb: new USB bus registered, assigned bus number 5
> [ 22.270160] xhci-hcd ee000000.usb: can't setup: -110
> [ 22.274931] xhci-hcd ee000000.usb: USB bus 5 deregistered
> [ 22.280158] xhci-hcd: probe of ee000000.usb failed with error -110
>
> Remarks:
> The timestamp doesn't work correctly on R-Car H3 ES1.0. It should be
> 10 seconds.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> arch/arm64/configs/defconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index a44ef99..a95751d 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1,7 +1,6 @@
> # CONFIG_LOCALVERSION_AUTO is not set
> CONFIG_SYSVIPC=y
> CONFIG_POSIX_MQUEUE=y
> -CONFIG_FHANDLE=y
> CONFIG_AUDIT=y
> CONFIG_NO_HZ_IDLE=y
> CONFIG_HIGH_RES_TIMERS=y
Is the hunk above intended?
It does not seem to match my reading of the changelog.
> @@ -192,7 +191,7 @@ CONFIG_SND_SOC_AK4613=y
> CONFIG_USB=y
> CONFIG_USB_OTG=y
> CONFIG_USB_XHCI_HCD=y
> -CONFIG_USB_XHCI_PLATFORM=y
> +CONFIG_USB_XHCI_RCAR=y
> CONFIG_USB_EHCI_HCD=y
> CONFIG_USB_EHCI_MSM=y
> CONFIG_USB_EHCI_HCD_PLATFORM=y
> --
> 1.9.1
next prev parent reply other threads:[~2016-04-21 3:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 8:47 [PATCH] arm64: defconfig: Add Renesas R-Car USB 3.0 driver support Yoshihiro Shimoda
2016-04-21 3:15 ` Simon Horman [this message]
2016-04-21 3:41 ` Yoshihiro Shimoda
[not found] ` <SG2PR06MB0919C567798F775F2685811ED86E0-ESzmfEwOt/zNQ8RBPPB5A20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-04-21 3:56 ` Simon Horman
[not found] ` <20160421035623.GB28575-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2016-04-21 9:44 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421031514.GB11116@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).