From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH 5/8] firmware: qcom: scm: Use atomic SCM for cold boot Date: Fri, 22 Apr 2016 16:50:05 -0700 Message-ID: <20160422235005.GI3202@tuxbot> References: <1461363432-5730-1-git-send-email-andy.gross@linaro.org> <1461363432-5730-6-git-send-email-andy.gross@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1461363432-5730-6-git-send-email-andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Gross Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Stephen Boyd , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Bjorn Andersson , jilai wang List-Id: devicetree@vger.kernel.org On Fri 22 Apr 15:17 PDT 2016, Andy Gross wrote: > This patch changes the cold_set_boot_addr function to use atomic SCM > calls. This removes the need for memory allocation and instead places > all arguments in registers. > > Signed-off-by: Andy Gross > --- > drivers/firmware/qcom_scm-32.c | 40 ++++++++++++++++++++++++++-------------- > 1 file changed, 26 insertions(+), 14 deletions(-) > > diff --git a/drivers/firmware/qcom_scm-32.c b/drivers/firmware/qcom_scm-32.c [..] > /* > * Set the cold/warm boot address for one of the CPU cores. > */ > -static int qcom_scm_set_boot_addr(u32 addr, int flags) > +static int qcom_scm_set_boot_addr(u32 addr, int flags, bool do_atomic) > { > struct { > __le32 flags; > __le32 addr; > } cmd; > > - cmd.addr = cpu_to_le32(addr); > - cmd.flags = cpu_to_le32(flags); > - return qcom_scm_call(QCOM_SCM_SVC_BOOT, QCOM_SCM_BOOT_ADDR, > - &cmd, sizeof(cmd), NULL, 0); > + if (do_atomic) { > + return qcom_scm_call_atomic(QCOM_SCM_SVC_BOOT, > + QCOM_SCM_BOOT_ADDR, 2, flags, addr); > + } else { > + > + cmd.addr = cpu_to_le32(addr); > + cmd.flags = cpu_to_le32(flags); > + > + return qcom_scm_call(QCOM_SCM_SVC_BOOT, QCOM_SCM_BOOT_ADDR, > + &cmd, sizeof(cmd), NULL, 0); > + } I would prefer that you split this into two functions, rather than hiding two functions bodies in one function. Perhaps qcom_scm_set_boot_addr and qcom_scm_set_boot_addr_atomic? > } > Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html