Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

[Andrew Lunn <andrew@lunn.ch>]

> Does the compatible property of the phy node (for the external phy)
> need to list the actual external phy?  That is, should it look like
> this:
> 
> 	phy0: ethernet-phy@0 {
> 		compatible = "qcom,fsm9900-emac-phy";
> 		reg = <0>;
> 	}
> 
> or this:
> 
> 	phy0: ethernet-phy@0 {
> 		compatible = "athr,whatever-phy";
> 		reg = <0>;
> 	}
> 

Documentation/devicetree/bindings/net/phy.txt says:

Optional Properties:

- compatible: Compatible list, may contain
  "ethernet-phy-ieee802.3-c22" or "ethernet-phy-ieee802.3-c45" for
  PHYs that implement IEEE802.3 clause 22 or IEEE802.3 clause 45
  specifications. If neither of these are specified, the default is to
  assume clause 22.

  If the phy's identifier is known then the list may contain an entry
  of the form: "ethernet-phy-idAAAA.BBBB" where
     AAAA - The value of the 16 bit Phy Identifier 1 register as
            4 hex digits. This is the chip vendor OUI bits 3:18
     BBBB - The value of the 16 bit Phy Identifier 2 register as
            4 hex digits. This is the chip vendor OUI bits 19:24,
            followed by 10 bits of a vendor specific ID.

  The compatible list should not contain other values than those
  listed here.

  Andrew