From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Dannenberg Subject: Re: [PATCH v3 1/2] ASoC: codecs: add TA5720 digital amplifier DT bindings Date: Tue, 26 Apr 2016 11:14:25 -0500 Message-ID: <20160426161425.GA2885@borg.dal.design.ti.com> References: <1461615456-19510-1-git-send-email-dannenberg@ti.com> <1461615456-19510-2-git-send-email-dannenberg@ti.com> <20160426153707.GZ3217@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20160426153707.GZ3217@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: Mark Rutland , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Rob Herring , Kumar Gala List-Id: devicetree@vger.kernel.org On Tue, Apr 26, 2016 at 04:37:07PM +0100, Mark Brown wrote: > On Mon, Apr 25, 2016 at 03:17:35PM -0500, Andreas Dannenberg wrote: > > > +Optional properties: > > + > > +- dvdd-supply : phandle to a 3.3-V supply for the digital circuitry > > +- pvdd-supply : phandle to a supply used for the Class-D amp and the analog > > This suggests that the device doesn't need power... Hi Mark, no power, now that would be nice! :) What this was supposed to mean is that the properties are optional, the power of course is not. The DT has really no control over how I wire up my HW and I'd argue most folks just permanently power the TAS5720 since the shutdown current is just a few uAs IIRC in order to save some BOM cost. But I suppose the DT description is such that the Kernel can more intelligently handle things based on what the driver is doing if somebody choses and implements additional regulator/power switch HW. Or did I misunderstand your point? Thanks, Andreas