From: Bjorn Helgaas <helgaas@kernel.org>
To: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Kumar Gala <galak@codeaurora.org>,
linux-arm-kernel@lists.infradead.org,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Nadav Haklai <nadavh@marvell.com>,
Lior Amsalem <alior@marvell.com>, Hanna Hawa <hannah@marvell.com>,
Yehuda Yitschak <yehuday@marvell.com>
Subject: Re: [PATCH v3 0/2] pci: host: new driver for Marvell Armada 7K/8K PCIe controller
Date: Tue, 26 Apr 2016 16:45:10 -0500 [thread overview]
Message-ID: <20160426214510.GA6789@localhost> (raw)
In-Reply-To: <20160426210850.13cc8a0e@free-electrons.com>
On Tue, Apr 26, 2016 at 09:08:50PM +0200, Thomas Petazzoni wrote:
> Hello,
>
> On Tue, 26 Apr 2016 12:31:44 -0500, Bjorn Helgaas wrote:
>
> > > create mode 100644 Documentation/devicetree/bindings/pci/pci-armada8k.txt
> > > create mode 100644 drivers/pci/host/pcie-armada8k.c
> >
> > Thanks, Thomas, I applied these to pci/host-armada for v4.7.
>
> Thanks!
>
> > I added the tweaks below to use dev_dbg() instead of pr_debug(), use
> > dw_pcie_wait_for_link() instead of another hand-coded timeout loop,
> > and fix a typo and remove unused constants.
>
> Looks all good, thanks for applying! Just one tiny question below.
>
> > /*
> > * Interrupts are directly handled by the device driver of the
> > - * PCI device. However, there are also latched into the PCIe
> > + * PCI device. However, they are also latched into the PCIe
>
> Any reason to have two spaces after the dot here?
Only habit because my eighth-grade typing teacher in 1979 did it that
way, and (I think) vim does it that way by default. Poor reasons,
both, and definitely trumped by consistency with the rest of the file,
which does use a single space in both other instances. I removed the
extra space :)
Bjorn
prev parent reply other threads:[~2016-04-26 21:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 8:31 [PATCH v3 0/2] pci: host: new driver for Marvell Armada 7K/8K PCIe controller Thomas Petazzoni
2016-04-26 8:31 ` [PATCH v3 1/2] dt-bindings: pci: add DT binding " Thomas Petazzoni
2016-04-26 8:31 ` [PATCH v3 2/2] pci: host: new driver " Thomas Petazzoni
[not found] ` <1461659506-10387-1-git-send-email-thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-04-26 17:31 ` [PATCH v3 0/2] " Bjorn Helgaas
2016-04-26 19:08 ` Thomas Petazzoni
2016-04-26 21:45 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160426214510.GA6789@localhost \
--to=helgaas@kernel.org \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregory.clement@free-electrons.com \
--cc=hannah@marvell.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nadavh@marvell.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=yehuday@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).