Re: [PATCH v2 3/3] MAINTAINERS: Add entry for Mali-DP driver

Emil Velikov
2016-04-25T17:53:26Z

On 25 April 2016 at 18:08, Liviu Dudau <Liviu.Dudau-5wv7dgnIgG8@public.gmane.org> wrote:
> On Mon, Apr 25, 2016 at 05:00:02PM +0100, Emil Velikov wrote:
>> On 25 April 2016 at 15:19, Liviu Dudau <Liviu.Dudau-5wv7dgnIgG8@public.gmane.org> wrote:
>> > Add MAINTAINERS entry for ARM Mali-DP driver and update the
>> > HDLCD file matching pattern to cover only HDLCD rather than
>> > the whole drivers/gpu/drm/arm directory.
>> >
>> > Signed-off-by: Liviu Dudau <Liviu.Dudau-5wv7dgnIgG8@public.gmane.org>
>> > ---
>> > MAINTAINERS | 10 +++++++++-
>> > 1 file changed, 9 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index 1d5b4be..a5a4346 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -850,9 +850,17 @@ F: include/uapi/linux/if_arcnet.h
>> > ARM HDLCD DRM DRIVER
>> > M: Liviu Dudau <liviu.dudau-5wv7dgnIgG8@public.gmane.org>
>> > S: Supported
>> > -F: drivers/gpu/drm/arm/
>> > +F: drivers/gpu/drm/arm/hdlcd_*
>> > F: Documentation/devicetree/bindings/display/arm,hdlcd.txt
>> >
>> > +ARM MALI-DP DRM DRIVER
>> > +M: Liviu Dudau <liviu.dudau-5wv7dgnIgG8@public.gmane.org>
>> > +M: Brian Starkey <brian.starkey-5wv7dgnIgG8@public.gmane.org>
>> > +M: Mali DP Maintainers <malidp-VeJGdqYn5oNWk0Htik3J/w@public.gmane.org>
>> > +S: Supported
>> > +F: drivers/gpu/drm/arm/
>> Woohoo. Thanks Liviu !
>>
>> Note that having both drivers' sources in the same folder will cause
>> some grief wrt getting the correct maintainer. If you want to avoid
>> that the easiest way is to move things in subdirectories roughly like:
>>
>> drivers/gpu/arm/hdlcd/
>> drivers/gpu/arm/mapidp/
>
> I'm surprised to hear that there might be problems. All HDLCD files start
> with hdlcd_ and the rest will go to the Mali-DP DRM maintainers (which includes
> me as well).
>
You're absolutely right. I read things the wrong way - the MaliDP
maintainers will be added for the HDLCD patches. Which obviously isn't
the case.

> I understand your suggestion and I thank for it, but I really hate to have
> to navigate too many directories (for now). Lets see how things evolve and then
> we can move stuff around.
>
IIRC DRM had the same structure (all drivers living in a single a
folder) before 2008, before people got fed up.
Feel free to do as you wish, just pointing out some historical observations ;-)

Regardless of my suggestions/nitpicks, thanks for all the work Liviu !
It's really nice to see more vendors contributing to DRM.

Regards,
Emil
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html