devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Jianqun Xu <jay.xu@rock-chips.com>
Cc: lintao@rock-chips.com, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, catalin.marinas@arm.com,
	will.deacon@arm.com, heiko@sntech.de, huangtao@rock-chips.com,
	davidriley@chromium.org, dianders@chromium.org,
	jwerner@chromium.org, smbarber@chromium.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v4 2/4] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs
Date: Thu, 28 Apr 2016 09:03:53 -0700	[thread overview]
Message-ID: <20160428160353.GA95284@google.com> (raw)
In-Reply-To: <1461743693-10671-3-git-send-email-jay.xu@rock-chips.com>

Hi Heiko, Jianqun,

On Wed, Apr 27, 2016 at 03:54:51PM +0800, Jianqun Xu wrote:
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> new file mode 100644
> index 0000000..5a8a915
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -0,0 +1,1022 @@
[...]
> +	sdhci: sdhci@fe330000 {
> +		compatible = "rockchip,rk3399-sdhci-5.1", "arasan,sdhci-5.1";

Not to rain on the parade too much, as this is already applied, but is
the "rockchip,rk3399-sdhci-5.1" string documented anywhere? I don't see
it.

> +		reg = <0x0 0xfe330000 0x0 0x10000>;
> +		interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&cru SCLK_EMMC>, <&cru ACLK_EMMC>;
> +		clock-names = "clk_xin", "clk_ahb";
> +		status = "disabled";
> +	};

[...]

Brian

  parent reply	other threads:[~2016-04-28 16:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-27  7:54 [PATCH v4 0/4] ARM64: dts: rockchip: add support for RK3399 Jianqun Xu
2016-04-27  7:54 ` [PATCH v4 1/4] Documentation: rockchip-dw-mshc: add description for rk3399 Jianqun Xu
     [not found]   ` <1461743693-10671-2-git-send-email-jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-04-27 21:30     ` Heiko Stübner
2016-04-27  7:54 ` [PATCH v4 2/4] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs Jianqun Xu
2016-04-27 21:30   ` Heiko Stübner
2016-04-28 16:03   ` Brian Norris [this message]
     [not found]     ` <20160428160353.GA95284-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-04-28 18:29       ` Brian Norris
     [not found]         ` <20160428182938.GA3079-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-04-28 20:33           ` Heiko Stübner
2016-04-28 22:28             ` Brian Norris
2016-04-27  7:54 ` [PATCH v4 3/4] Documentation: devicetree: rockchip: Document rk3399-evb Jianqun Xu
2016-04-27 21:30   ` Heiko Stübner
     [not found] ` <1461743693-10671-1-git-send-email-jay.xu-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-04-27  7:54   ` [PATCH v4 4/4] ARM64: dts: rockchip: add dts file for RK3399 evaluation board Jianqun Xu
2016-04-27 21:31     ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160428160353.GA95284@google.com \
    --to=briannorris@chromium.org \
    --cc=catalin.marinas@arm.com \
    --cc=davidriley@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=huangtao@rock-chips.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=jay.xu@rock-chips.com \
    --cc=jwerner@chromium.org \
    --cc=lintao@rock-chips.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=smbarber@chromium.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).