From: Rob Herring <robh@kernel.org>
To: Amitkumar Karwar <akarwar@marvell.com>
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Wei-Ning Huang <wnhuang@chromium.org>,
Xinming Hu <huxm@marvell.com>
Subject: Re: [PATCH v8 1/2] dt: bindings: add MARVELL's bt-sd8xxx wireless device
Date: Thu, 28 Apr 2016 15:50:14 -0500 [thread overview]
Message-ID: <20160428205014.GA4893@rob-hp-laptop> (raw)
In-Reply-To: <1461679047-22631-1-git-send-email-akarwar@marvell.com>
On Tue, Apr 26, 2016 at 06:57:26AM -0700, Amitkumar Karwar wrote:
> From: Xinming Hu <huxm@marvell.com>
>
> Add device tree binding documentation for MARVELL's bluetooth sdio
> (sd8897 and sd8997) chip.
>
> Signed-off-by: Xinming Hu <huxm@marvell.com>
> Signed-off-by: Amitkumar Karwar <akarwar@marvell.com>
> ---
> Listing changelist for both 1/2 and 2/2 here
> v2: Fixed build error reported by kbuild test robot
> drivers/bluetooth/btmrvl_platform.c:141:22: error:
> 'btmrvl_plt_pm_ops' undeclared here (not in a function)
>
> v3: Add NULL check for 'btmrvl_plt_dev'
>
> v4: Moved the bindings file to bindings/net/
> Corrected the name of 'name' and 'compatible' properties(Rob Herring)
>
> v5: Comments for wlan patches were applicable here as well. Like all binding
> changes in single file, specifying node as a child of SDIO controller.
>
> v6: a)Use <chip>-bt order for compatible attribute(Rob Herring)
> b)Split wakeuppin-gap to wakeup-pin and wakeup-gap(Rob Herring)
> c)Use sdio function number for both the unit address and reg(Rob Herring)
>
> v7: a)Use suggested vendor name and generic node name(Rob Herring)
> v8: a)Nodes are renamed as per suggestions from Rob Herring
> btmrvl,* -> marvell,*
> "wakeup-gap-msec" -> "wakeup-gap-ms"
> ---
> Documentation/devicetree/bindings/btmrvl.txt | 29 -----------
> .../devicetree/bindings/net/marvell-bt-sd8xxx.txt | 56 ++++++++++++++++++++++
> 2 files changed, 56 insertions(+), 29 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/btmrvl.txt
> create mode 100644 Documentation/devicetree/bindings/net/marvell-bt-sd8xxx.txt
Thanks for getting this old binding fixed.
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2016-04-28 20:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 13:57 [PATCH v8 1/2] dt: bindings: add MARVELL's bt-sd8xxx wireless device Amitkumar Karwar
[not found] ` <1461679047-22631-1-git-send-email-akarwar-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2016-04-26 13:57 ` [PATCH v8 2/2] btmrvl: add platform specific wakeup interrupt support Amitkumar Karwar
[not found] ` <1461679047-22631-2-git-send-email-akarwar-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2016-05-02 17:28 ` Marcel Holtmann
2016-04-28 20:50 ` Rob Herring [this message]
2016-05-02 17:28 ` [PATCH v8 1/2] dt: bindings: add MARVELL's bt-sd8xxx wireless device Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160428205014.GA4893@rob-hp-laptop \
--to=robh@kernel.org \
--cc=akarwar@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=huxm@marvell.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wnhuang@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).