From: Rob Herring <robh@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Grant Likely <grant.likely@linaro.org>,
Dave Airlie <airlied@redhat.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Frank Rowand <frowand.list@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] of: include errno.h in of_graph.h
Date: Mon, 2 May 2016 09:00:32 -0500 [thread overview]
Message-ID: <20160502140032.GA12801@rob-hp-laptop> (raw)
In-Reply-To: <1462186769-2205767-1-git-send-email-arnd@arndb.de>
On Mon, May 02, 2016 at 12:59:19PM +0200, Arnd Bergmann wrote:
> When CONFIG_OF is disabled, we have to include linux/errno.h before
> including of_graph.h, or get build errors like in the newly added
> sun4i drm driver:
>
> In file included from ../drivers/gpu/drm/sun4i/sun4i_drv.c:14:0:
> include/linux/of_graph.h: In function 'of_graph_parse_endpoint':
> include/linux/of_graph.h:58:10: error: 'ENOSYS' undeclared (first use in this function)
>
> A better solution is to ensure that the header can be included
> by itself, so let's include linux/errno.h here to fix the error
> we just got, and any similar future error.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 9026e0d122ac ("drm: Add Allwinner A10 Display Engine support")
> ---
> include/linux/of_graph.h | 1 +
> 1 file changed, 1 insertion(+)
Applied.
Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-05-02 14:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-02 10:59 [PATCH] of: include errno.h in of_graph.h Arnd Bergmann
2016-05-02 14:00 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160502140032.GA12801@rob-hp-laptop \
--to=robh@kernel.org \
--cc=airlied@redhat.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox