From: Thierry Reding <thierry.reding@gmail.com>
To: Wei Ni <wni@nvidia.com>
Cc: robh+dt@kernel.org, swarren@wwwdotorg.org,
linux-tegra@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node
Date: Tue, 3 May 2016 17:21:11 +0200 [thread overview]
Message-ID: <20160503152111.GC19539@ulmo.ba.sec> (raw)
In-Reply-To: <1462266577-951-1-git-send-email-wni@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 652 bytes --]
On Tue, May 03, 2016 at 05:09:37PM +0800, Wei Ni wrote:
> This patch changes the compatible of Tegra132 fuse node
> to "nvidia,tegra132-efuse", instead of "nvidia,tegra1124-efuse".
> Because the CONFIG_ARCH_TEGRA_124_SOC will not be enabled for
> Tegra132, the fuse driver can't find the corresponding node.
Okay, that's not really a good reason to modify the DTS. What we should
do instead is make sure that the OF table contains the entry on Tegra132
builds. Unless the IP block really is different and Tegra124 and
Tegra132 aren't compatible in this regard after all.
In the latter case the commit message should reflect the real reason.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-05-03 15:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 9:09 [PATCH] arm64: tegra: fix compatible string for Tegra132 fuse node Wei Ni
2016-05-03 15:21 ` Thierry Reding [this message]
[not found] ` <20160503152111.GC19539-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2016-05-04 2:25 ` Wei Ni
[not found] ` <57295DAF.1050800-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-05-04 7:32 ` Wei Ni
-- strict thread matches above, loose matches on Subject: below --
2016-05-03 9:32 Wei Ni
2016-05-03 10:11 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503152111.GC19539@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=wni@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).