From: Rob Herring <robh@kernel.org>
To: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
Cc: mkl@pengutronix.de, wg@grandegger.com, socketcan@hartkopp.net,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
chris.paterson2@renesas.com
Subject: Re: [PATCH v5 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver
Date: Tue, 3 May 2016 11:47:28 -0500 [thread overview]
Message-ID: <20160503164728.GA32640@rob-hp-laptop> (raw)
In-Reply-To: <1461846188-31249-2-git-send-email-ramesh.shanmugasundaram@bp.renesas.com>
On Thu, Apr 28, 2016 at 01:23:07PM +0100, Ramesh Shanmugasundaram wrote:
> This patch adds support for the CAN FD controller found in Renesas R-Car
> SoCs. The controller operates in CAN FD only mode by default.
>
> CAN FD mode supports both Classical CAN & CAN FD frame formats. The
> controller supports ISO 11898-1:2015 CAN FD format only.
>
> This controller supports two channels and the driver can enable either
> or both of the channels.
>
> Driver uses Rx FIFOs (one per channel) for reception & Common FIFOs (one
> per channel) for transmission. Rx filter rules are configured to the
> minimum (one per channel) and it accepts Standard, Extended, Data &
> Remote Frame combinations.
>
> Note: There are few documentation errors in R-Car Gen3 Hardware User
> Manual v0.5E with respect to CAN FD controller. They are listed below:
>
> 1. CAN FD interrupt numbers 29 & 30 are listed as per channel
> interrupts. However, they are common to both channels (i.e.) they are
> global and channel interrupts respectively.
>
> 2. CANFD clock is derived from PLL1. This is not documented.
>
> 3. CANFD clock is further divided by (1/2) within the CAN FD controller.
> This is not documented.
>
> 4. The minimum value of NTSEG1 in RSCFDnCFDCmNCFG register is 2 Tq. It
> is specified 4 Tq in the manual.
>
> 5. The maximum number of message RAM area the controller can use is 3584
> bytes. It is specified 10752 bytes in the manual.
>
> Signed-off-by: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com>
> ---
> .../devicetree/bindings/net/can/rcar_canfd.txt | 89 ++
What happened to my ack?
> drivers/net/can/Kconfig | 1 +
> drivers/net/can/Makefile | 1 +
> drivers/net/can/rcar/Kconfig | 11 +
> drivers/net/can/rcar/Makefile | 5 +
> drivers/net/can/rcar/rcar_canfd.c | 1624 ++++++++++++++++++++
> 6 files changed, 1731 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/can/rcar_canfd.txt
> create mode 100644 drivers/net/can/rcar/Kconfig
> create mode 100644 drivers/net/can/rcar/Makefile
> create mode 100644 drivers/net/can/rcar/rcar_canfd.c
next prev parent reply other threads:[~2016-05-03 16:47 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 9:34 [PATCH] can: rcar_canfd: Add Renesas R-Car CAN FD driver Ramesh Shanmugasundaram
[not found] ` <1456824849-7987-1-git-send-email-ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org>
2016-03-01 20:41 ` Marc Kleine-Budde
2016-03-02 8:41 ` Ramesh Shanmugasundaram
2016-03-02 9:20 ` Marc Kleine-Budde
2016-03-02 10:08 ` Ramesh Shanmugasundaram
2016-03-02 10:21 ` Marc Kleine-Budde
2016-03-03 13:48 ` Ramesh Shanmugasundaram
2016-03-01 21:07 ` Oliver Hartkopp
2016-03-02 8:45 ` Ramesh Shanmugasundaram
2016-03-03 15:38 ` [PATCH v2] " Ramesh Shanmugasundaram
2016-03-05 4:30 ` Rob Herring
2016-03-07 9:33 ` Ramesh Shanmugasundaram
2016-03-06 11:32 ` Oliver Hartkopp
2016-03-07 8:02 ` Ramesh Shanmugasundaram
2016-03-07 8:08 ` Marc Kleine-Budde
2016-03-07 8:32 ` Ramesh Shanmugasundaram
2016-03-08 7:46 ` Oliver Hartkopp
2016-03-08 8:57 ` Ramesh Shanmugasundaram
2016-03-08 12:25 ` Oliver Hartkopp
2016-03-08 12:48 ` Ramesh Shanmugasundaram
2016-03-08 17:16 ` Oliver Hartkopp
2016-03-11 7:14 ` Ramesh Shanmugasundaram
2016-03-12 18:49 ` Oliver Hartkopp
2016-03-15 9:48 ` [PATCH v3] " Ramesh Shanmugasundaram
2016-03-15 12:51 ` Marc Kleine-Budde
2016-03-15 14:26 ` Ramesh Shanmugasundaram
2016-03-18 21:07 ` Rob Herring
2016-03-21 16:45 ` [PATCH v4 0/2] Add CAN FD driver support to r8a7795 SoC Ramesh Shanmugasundaram
2016-03-21 16:45 ` [PATCH 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver Ramesh Shanmugasundaram
2016-03-21 16:45 ` [PATCH 2/2] can: rcar_can: Move Renesas CAN driver to rcar dir Ramesh Shanmugasundaram
2016-03-31 20:51 ` [PATCH v2] can: rcar_canfd: Add Renesas R-Car CAN FD driver Marc Kleine-Budde
2016-04-01 12:48 ` Ramesh Shanmugasundaram
2016-04-13 6:25 ` Ramesh Shanmugasundaram
2016-04-28 6:27 ` Oliver Hartkopp
2016-04-28 12:31 ` Ramesh Shanmugasundaram
2016-04-28 12:23 ` [PATCH v5 0/2] Add CAN FD driver support to r8a7795 SoC Ramesh Shanmugasundaram
2016-04-28 12:23 ` [PATCH v5 1/2] can: rcar_canfd: Add Renesas R-Car CAN FD driver Ramesh Shanmugasundaram
2016-05-03 16:47 ` Rob Herring [this message]
2016-05-04 6:23 ` Ramesh Shanmugasundaram
2016-04-28 12:23 ` [PATCH v5 2/2] can: rcar_can: Move Renesas CAN driver to rcar dir Ramesh Shanmugasundaram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503164728.GA32640@rob-hp-laptop \
--to=robh@kernel.org \
--cc=chris.paterson2@renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-can@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=ramesh.shanmugasundaram@bp.renesas.com \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox