From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCHv3] ARM: dts: sunxi: Add a olinuxino-lime2-emmc Date: Wed, 4 May 2016 20:35:50 +0200 Message-ID: <20160504183550.GG17159@lukather> References: <1462367853-29912-1-git-send-email-oliver@schinagl.nl> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IJ0V8rSZ2aNZISPM" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <1462367853-29912-1-git-send-email-oliver-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Olliver Schinagl Cc: Chen-Yu Tsai , Tsvetan Usunov , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Hans de Goede , info-kyXcfZUBQGPQT0dZR+AlfA@public.gmane.org, dev-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org --IJ0V8rSZ2aNZISPM Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Wed, May 04, 2016 at 03:17:33PM +0200, Olliver Schinagl wrote: > There are 3 kinds of OLinuXino Lime2 boards. > One without any on board storage, one with NAND storage and one with > eMMC storage. This patch adds the eMMC variant of boards. > > eMMC storage is different from a regular SD card in that it is soldered > on the board and cannot be changed. Additionally, it shares pins with > the NAND module and with the second SPI port. > > Signed-off-by: Olliver Schinagl As a general comment, having a log of the changes helps a lot, especially when you roll new versions quiclky. > --- > .../boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts | 81 ++++++++++++++++++++++ > 1 file changed, 81 insertions(+) > create mode 100644 arch/arm/boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts > > diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts > new file mode 100644 > index 0000000..9680fcb > --- /dev/null > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-lime2-emmc.dts > @@ -0,0 +1,81 @@ > + /* > + * Copyright 2015 - Ultimaker B.V. > + * Author Olliver Schinagl > + * > + * This file is dual-licensed: you can use it either under the terms > + * of the GPL or the X11 license, at your option. Note that this dual > + * licensing only applies to this file, and not this project as a > + * whole. > + * > + * a) This file is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of the > + * License, or (at your option) any later version. > + * > + * This file is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * Or, alternatively, > + * > + * b) Permission is hereby granted, free of charge, to any person > + * obtaining a copy of this software and associated documentation > + * files (the "Software"), to deal in the Software without > + * restriction, including without limitation the rights to use, > + * copy, modify, merge, publish, distribute, sublicense, and/or > + * sell copies of the Software, and to permit persons to whom the > + * Software is furnished to do so, subject to the following > + * conditions: > + * > + * The above copyright notice and this permission notice shall be > + * included in all copies or substantial portions of the Software. > + * > + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, > + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES > + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND > + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT > + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, > + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR > + * OTHER DEALINGS IN THE SOFTWARE. > + */ > + > +#include "sun7i-a20-olinuxino-lime2.dts" > + > +/ { > + model = "Olimex A20-OLinuXino-LIME2-eMMC"; You should have a compatible here too. Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --IJ0V8rSZ2aNZISPM--