From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-renesas-soc@vger.kernel.org,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv3 1/4] ARM: dts: r8a7790: Reference both DMA controllers
Date: Wed, 11 May 2016 16:03:08 +0200 [thread overview]
Message-ID: <20160511140308.GD3256@bigcity.dyn.berto.se> (raw)
In-Reply-To: <CAMuHMdWoPThi0w6siA5LJ60oEH6JMv4x80b_Spg5aF-uHq3WqQ@mail.gmail.com>
On 2016-05-11 15:45:17 +0200, Geert Uytterhoeven wrote:
> Hi Niklas,
>
> On Wed, May 11, 2016 at 3:13 PM, Niklas Söderlund
> <niklas.soderlund+renesas@ragnatech.se> wrote:
> > R-Car Gen2 have two DMA controllers, which are equivalent. Add
> > references to both dmac0 and dmac1 so the driver can choose which one to
> > use.
> >
> > Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> > ---
> > arch/arm/boot/dts/r8a7790.dtsi | 131 ++++++++++++++++++++++++-----------------
> > 1 file changed, 78 insertions(+), 53 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
> > index 83cf23c..14fcd19 100644
> > --- a/arch/arm/boot/dts/r8a7790.dtsi
> > +++ b/arch/arm/boot/dts/r8a7790.dtsi
>
> > @@ -755,9 +773,9 @@
> > clocks = <&mstp3_clks R8A7790_CLK_SCIF2>, <&zs_clk>,
> > <&scif_clk>;
> > clock-names = "fck", "brg_int", "scif_clk";
> > - dmas = <&dmac0 0x2b>, <&dmac0 0x2c>;
> > - dma-names = "tx", "rx";
> > - power-domains = <&sysc R8A7790_PD_ALWAYS_ON>;
>
> Please keep the above line.
My mistake, the above line was not meant to be removed.. thanks for
pointing it out.
>
> > + dmas = <&dmac0 0x2b>, <&dmac0 0x2c>,
> > + <&dmac1 0x2b>, <&dmac1 0x2c>;
> > + dma-names = "tx", "rx", "tx", "rx";
> > status = "disabled";
> > };
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2016-05-11 14:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 13:13 [PATCHv3 0/4] ARM: dts: r8a779[0-4]: Reference both DMA controllers Niklas Söderlund
[not found] ` <1462972438-20797-1-git-send-email-niklas.soderlund+renesas-1zkq55x86MTxsAP9Fp7wbw@public.gmane.org>
2016-05-11 13:13 ` [PATCHv3 1/4] ARM: dts: r8a7790: " Niklas Söderlund
2016-05-11 13:45 ` Geert Uytterhoeven
2016-05-11 14:03 ` Niklas Söderlund [this message]
2016-05-11 13:13 ` [PATCHv3 2/4] ARM: dts: r8a7791: " Niklas Söderlund
2016-05-11 13:13 ` [PATCHv3 3/4] ARM: dts: r8a7793: " Niklas Söderlund
2016-05-11 13:46 ` [PATCHv3 0/4] ARM: dts: r8a779[0-4]: " Geert Uytterhoeven
2016-05-11 13:13 ` [PATCHv3 4/4] ARM: dts: r8a7794: " Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511140308.GD3256@bigcity.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).