* [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board
@ 2016-05-11 7:06 Krzysztof Kozlowski
2016-05-11 18:18 ` Matthew Leach
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2016-05-11 7:06 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Matthew Leach, Bartlomiej Zolnierkiewicz
From: Matthew Leach <matthew@mattleach.net>
Enable the Origen's usb phy and ohci devices in the device tree. Also
add the "samsung,vbus-gpio" property to enable the GPX3(5) gpio pin so
the AX88760 hub is powered.
Signed-off-by: Matthew Leach <matthew@mattleach.net>
[k.kozlowski: Extend nodes by label notation instead of path]
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
arch/arm/boot/dts/exynos4412-origen.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
index 8bca699b7f20..4c59bdb0e6f3 100644
--- a/arch/arm/boot/dts/exynos4412-origen.dts
+++ b/arch/arm/boot/dts/exynos4412-origen.dts
@@ -77,12 +77,29 @@
clock-frequency = <24000000>;
};
};
+
};
&cpu0 {
cpu0-supply = <&buck2_reg>;
};
+&exynos_usbphy {
+ status = "okay";
+};
+
+&ehci {
+ samsung,vbus-gpio = <&gpx3 5 1>;
+ status = "okay";
+
+ port@1{
+ status = "okay";
+ };
+ port@2 {
+ status = "okay";
+ };
+};
+
&fimd {
pinctrl-0 = <&lcd_clk &lcd_data24 &pwm1_out>;
pinctrl-names = "default";
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board
2016-05-11 7:06 [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board Krzysztof Kozlowski
@ 2016-05-11 18:18 ` Matthew Leach
2016-05-11 18:53 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Leach @ 2016-05-11 18:18 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, linux-samsung-soc, Bartlomiej Zolnierkiewicz,
linux-kernel, Kukjin Kim, linux-arm-kernel
Hi Krzysztof,
Sorry for not acting on the feedback sooner - I lost the email in my
Inbox!
I've tested the patch on my Origen board and it works fine. One small
comment in-line.
Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:
> From: Matthew Leach <matthew@mattleach.net>
>
> Enable the Origen's usb phy and ohci devices in the device tree. Also
> add the "samsung,vbus-gpio" property to enable the GPX3(5) gpio pin so
> the AX88760 hub is powered.
>
> Signed-off-by: Matthew Leach <matthew@mattleach.net>
> [k.kozlowski: Extend nodes by label notation instead of path]
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> arch/arm/boot/dts/exynos4412-origen.dts | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
> index 8bca699b7f20..4c59bdb0e6f3 100644
> --- a/arch/arm/boot/dts/exynos4412-origen.dts
> +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> @@ -77,12 +77,29 @@
> clock-frequency = <24000000>;
> };
> };
> +
I think we could loose this line break?
Thanks,
--
Matt
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board
2016-05-11 18:18 ` Matthew Leach
@ 2016-05-11 18:53 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2016-05-11 18:53 UTC (permalink / raw)
To: Matthew Leach
Cc: Krzysztof Kozlowski, devicetree, linux-samsung-soc,
Bartlomiej Zolnierkiewicz, linux-kernel, Kukjin Kim,
linux-arm-kernel
On Wed, May 11, 2016 at 07:18:31PM +0100, Matthew Leach wrote:
> Hi Krzysztof,
>
> Sorry for not acting on the feedback sooner - I lost the email in my
> Inbox!
>
> I've tested the patch on my Origen board and it works fine. One small
> comment in-line.
>
> Krzysztof Kozlowski <k.kozlowski@samsung.com> writes:
>
> > From: Matthew Leach <matthew@mattleach.net>
> >
> > Enable the Origen's usb phy and ohci devices in the device tree. Also
> > add the "samsung,vbus-gpio" property to enable the GPX3(5) gpio pin so
> > the AX88760 hub is powered.
> >
> > Signed-off-by: Matthew Leach <matthew@mattleach.net>
> > [k.kozlowski: Extend nodes by label notation instead of path]
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > ---
> > arch/arm/boot/dts/exynos4412-origen.dts | 17 +++++++++++++++++
> > 1 file changed, 17 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/exynos4412-origen.dts b/arch/arm/boot/dts/exynos4412-origen.dts
> > index 8bca699b7f20..4c59bdb0e6f3 100644
> > --- a/arch/arm/boot/dts/exynos4412-origen.dts
> > +++ b/arch/arm/boot/dts/exynos4412-origen.dts
> > @@ -77,12 +77,29 @@
> > clock-frequency = <24000000>;
> > };
> > };
> > +
>
> I think we could loose this line break?
Yeah, that slipped through my fingers.
Thanks for testing,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-11 18:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-11 7:06 [PATCH] ARM: dts: exynos: Enable AX88760 USB hub on Origen board Krzysztof Kozlowski
2016-05-11 18:18 ` Matthew Leach
2016-05-11 18:53 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).