Re: [PATCH v2 1/3] Documentation: mfd: LP873X: Add information for the mfd and regulator drivers

[Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>]

On Tue, 10 May 2016, Keerthy wrote:

> Add information for the mfd and regulator drivers.
> 
> Signed-off-by: Keerthy <j-keerthy-l0cyMroinI0@public.gmane.org>
> ---
>  Documentation/devicetree/bindings/mfd/lp873x.txt | 55 ++++++++++++++++++++++++
>  1 file changed, 55 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/lp873x.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/lp873x.txt b/Documentation/devicetree/bindings/mfd/lp873x.txt
> new file mode 100644
> index 0000000..3ef5ea0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/lp873x.txt
> @@ -0,0 +1,55 @@
> +TI LP3943 MFD driver
> +
> +Required properties:
> +  - compatible: "ti,lp8732", "ti,lp8733"
> +  - reg: I2C slave address.
> +
> +For the lp873x regulator properties please refer to:
> +Documentation/devicetree/bindings/regulator/lp873x.txt

This is a Linuxism.  Use ../bindings/.. instead.

> +Example:
> +
> +lp8733: lp8733@60 {

lp8733 is not a device 'type'.  What does it do?

Looks like a 'pmic' to me.

> +	compatible = "ti,lp8733";
> +	reg = <0x60>;
> +
> +	regulators {
> +		lp8733_buck0: buck0 {
> +			regulator-name = "lp8733-buck0";
> +			regulator-min-microvolt = <800000>;
> +			regulator-max-microvolt = <1400000>;
> +			regulator-min-microamp = <1500000>;
> +			regulator-max-microamp = <4000000>;
> +			regulator-ramp-delay = <10000>;
> +			regulator-always-on;
> +			regulator-boot-on;
> +		};
> +
> +		lp8733_buck1: buck1 {
> +			regulator-name = "lp8733-buck1";
> +			regulator-min-microvolt = <800000>;
> +			regulator-max-microvolt = <1400000>;
> +			regulator-min-microamp = <1500000>;
> +			regulator-max-microamp = <4000000>;
> +			regulator-ramp-delay = <10000>;
> +			regulator-boot-on;
> +			regulator-always-on;
> +		};
> +
> +		lp8733_ldo0: ldo0 {
> +			regulator-name = "lp8733-ldo0";
> +			regulator-min-microvolt = <800000>;
> +			regulator-max-microvolt = <3000000>;
> +			regulator-boot-on;
> +			regulator-always-on;
> +		};
> +
> +		lp8733_ldo1: ldo1 {
> +			regulator-name = "lp8733-ldo1";
> +			regulator-min-microvolt = <800000>;
> +			regulator-max-microvolt = <3000000>;
> +			regulator-always-on;
> +			regulator-boot-on;
> +		};
> +	};
> +};

I'm failing to see how this is an MFD?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html