[PATCH] ARM: dts: omap5-igep0050: Correct hdmi regulator

[PATCH] ARM: dts: omap5-igep0050: Correct hdmi regulator

[Peter Ujfalusi]

ldo7_reg should not work as regulator since it is set to 'disabled' state
in the omap5-board-common.dtsi and the state is not changed to 'okay'
this means that the ldo7_reg is not available to be used in the igep0050
DTS file.
ldo4_reg is used by all other OMAP5 boards and this is most likely the
correct regulator to use with hdmi.
The hdmi needs 1.8V, but the ldo7_reg, based on the dtsi is 2V only.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
Tony,

I don't have access to the schematics, but I believe tha the ldo7_reg is not the
correct regulator to be used for hdmi.

If you have access and it is really ldo7_reg, then we should have this in the
omap5-igep0050.dts file:

&ldo5_reg {
	status = "okay";
	regulator-min-microvolt = <1800000>;
	regulator-max-microvolt = <1800000>;
};

Regards,
Peter

 arch/arm/boot/dts/omap5-igep0050.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts
index 46ecb1dd3b5c..6c8d40327c68 100644
--- a/arch/arm/boot/dts/omap5-igep0050.dts
+++ b/arch/arm/boot/dts/omap5-igep0050.dts
@@ -20,7 +20,7 @@
 };
 
 &hdmi {
-	vdda-supply = <&ldo7_reg>;
+	vdda-supply = <&ldo4_reg>;
 };
 
 &i2c4 {
-- 
2.8.1

Re: [PATCH] ARM: dts: omap5-igep0050: Correct hdmi regulator

[Peter Ujfalusi]

On 04/29/16 13:21, Peter Ujfalusi wrote:
> ldo7_reg should not work as regulator since it is set to 'disabled' state
> in the omap5-board-common.dtsi and the state is not changed to 'okay'
> this means that the ldo7_reg is not available to be used in the igep0050
> DTS file.
> ldo4_reg is used by all other OMAP5 boards and this is most likely the
> correct regulator to use with hdmi.
> The hdmi needs 1.8V, but the ldo7_reg, based on the dtsi is 2V only.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
> ---
> Tony,
> 
> I don't have access to the schematics, but I believe tha the ldo7_reg is not the
> correct regulator to be used for hdmi.
> 
> If you have access and it is really ldo7_reg, then we should have this in the
> omap5-igep0050.dts file:
> 
> &ldo5_reg {

ldo7_reg, obviously ;)

> 	status = "okay";
> 	regulator-min-microvolt = <1800000>;
> 	regulator-max-microvolt = <1800000>;
> };
> 
> Regards,
> Peter
> 
>  arch/arm/boot/dts/omap5-igep0050.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts
> index 46ecb1dd3b5c..6c8d40327c68 100644
> --- a/arch/arm/boot/dts/omap5-igep0050.dts
> +++ b/arch/arm/boot/dts/omap5-igep0050.dts
> @@ -20,7 +20,7 @@
>  };
>  
>  &hdmi {
> -	vdda-supply = <&ldo7_reg>;
> +	vdda-supply = <&ldo4_reg>;
>  };
>  
>  &i2c4 {
> 


-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: omap5-igep0050: Correct hdmi regulator

[Tony Lindgren]

Hi,

Adding Nishanth to Cc.

* Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org> [160429 05:15]:
> ldo7_reg, obviously ;)
> 
> > 	status = "okay";
> > 	regulator-min-microvolt = <1800000>;
> > 	regulator-max-microvolt = <1800000>;
> > };

It really seems to be ldo7, otherwise there's no HDMI output. I don't
have the schematics either.

But it seems we have at least two other regressions in Linux next that
prevent me from testing this properly:

1. On igepv5, I get this for the MMC regulator

ldo9: bypassed regulator has no supply!
ldo9: failed to get the current voltage(-517)
palmas-pmic 48070000.i2c:palmas@48:palmas_pmic: failed to register 48070000.i2c:palmar

I'm pretty sure it really is using the ldo9 for MMC just like
omap5-uevm.. Nishanth suggested it may use something else, but
why would it as ldo9 has a nice voltage range?

2. On both omap5-uevm and igepv5, NFSroot hangs

It seems that NFSroot boots to the point where PM runtime now
just shuts down some regulator affecting the USB connected
smsc Ethernet adapter?

Regards,

Tony


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: omap5-igep0050: Correct hdmi regulator

[Nishanth Menon]

On 05/04/2016 12:26 PM, Tony Lindgren wrote:
> Hi,
> 
> Adding Nishanth to Cc.
> 
> * Peter Ujfalusi <peter.ujfalusi@ti.com> [160429 05:15]:
>> ldo7_reg, obviously ;)
>>
>>> 	status = "okay";
>>> 	regulator-min-microvolt = <1800000>;
>>> 	regulator-max-microvolt = <1800000>;
>>> };
> 
> It really seems to be ldo7, otherwise there's no HDMI output. I don't
> have the schematics either.
> 
> But it seems we have at least two other regressions in Linux next that
> prevent me from testing this properly:
> 
> 1. On igepv5, I get this for the MMC regulator
> 
> ldo9: bypassed regulator has no supply!
> ldo9: failed to get the current voltage(-517)
> palmas-pmic 48070000.i2c:palmas@48:palmas_pmic: failed to register 48070000.i2c:palmar
> 
> I'm pretty sure it really is using the ldo9 for MMC just like
> omap5-uevm.. Nishanth suggested it may use something else, but
> why would it as ldo9 has a nice voltage range?
> 
> 2. On both omap5-uevm and igepv5, NFSroot hangs
> 
> It seems that NFSroot boots to the point where PM runtime now
> just shuts down some regulator affecting the USB connected
> smsc Ethernet adapter?
> 
> Regards,

This one is interesting..
BayLibre uEVM:
https://storage.kernelci.org/next/next-20160504/arm-omap2plus_defconfig/lab-baylibre-seattle/boot-omap5-uevm_rootfs:mmc.txt

My uEVM:
https://github.com/nmenon/kernel-test-logs/blob/next-20160504/omap2plus_defconfig/omap5-evm.txt

Mine boots, but BayLibre one does not. So, that got me started
thinking it was bootloader... but then I realize it could be SDCard
since they are dual voltage. U-boot starting v2013.07-rc1 included
code that would set to bypass or program voltage for LDO9 based on
card voltage needed. It is possible (since my card seems to need 3.0v,
not 3.3v), that bypass to VCC_3v3_SDIO was never needed - but the
cards that Baylibre board could probably be setup in bypass.

I will send in a patch assuming (without access to igev5 schematics -
based on how it seems to be booting), that sdio path.


-- 
Regards,
Nishanth Menon

Re: [PATCH] ARM: dts: omap5-igep0050: Correct hdmi regulator

[Tony Lindgren]

* Nishanth Menon <nm-l0cyMroinI0@public.gmane.org> [160504 11:03]:
> On 05/04/2016 12:26 PM, Tony Lindgren wrote:
> > Hi,
> > 
> > Adding Nishanth to Cc.
> > 
> > * Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org> [160429 05:15]:
> >> ldo7_reg, obviously ;)
> >>
> >>> 	status = "okay";
> >>> 	regulator-min-microvolt = <1800000>;
> >>> 	regulator-max-microvolt = <1800000>;
> >>> };
> > 
> > It really seems to be ldo7, otherwise there's no HDMI output. I don't
> > have the schematics either.
> > 
> > But it seems we have at least two other regressions in Linux next that
> > prevent me from testing this properly:
> > 
> > 1. On igepv5, I get this for the MMC regulator
> > 
> > ldo9: bypassed regulator has no supply!
> > ldo9: failed to get the current voltage(-517)
> > palmas-pmic 48070000.i2c:palmas@48:palmas_pmic: failed to register 48070000.i2c:palmar

The patch I posted fixes this. Then for the HDMI see below.
I've kept it at 2V like we have in omap5-board-common.dtsi,
I wonder if it really should be 1.8V though for ldo7 in this
case?

Regards,

Tony
8< -----------------
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
Date: Thu, 5 May 2016 11:29:23 -0700
Subject: [PATCH] ARM: dts: Fix ldo7 source for HDMI on igepv5

Fix ldo7 source for HDMI on igepv5.

Suggested-by: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
Signed-off-by: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>

diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts
index 46ecb1d..72ff6a4 100644
--- a/arch/arm/boot/dts/omap5-igep0050.dts
+++ b/arch/arm/boot/dts/omap5-igep0050.dts
@@ -35,6 +35,12 @@
 	};
 };
 
+&ldo7_reg {
+	status = "okay";
+	regulator-min-microvolt = <2000000>;
+	regulator-max-microvolt = <2000000>;
+};
+
 &omap5_pmx_core {
 	i2c4_pins: pinmux_i2c4_pins {
 		pinctrl-single,pins = <
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: dts: omap5-igep0050: Correct hdmi regulator

[Peter Ujfalusi]

Adding Tomi,

On 05/05/16 21:46, Tony Lindgren wrote:
> * Nishanth Menon <nm@ti.com> [160504 11:03]:
>> On 05/04/2016 12:26 PM, Tony Lindgren wrote:
>>> Hi,
>>>
>>> Adding Nishanth to Cc.
>>>
>>> * Peter Ujfalusi <peter.ujfalusi@ti.com> [160429 05:15]:
>>>> ldo7_reg, obviously ;)
>>>>
>>>>> 	status = "okay";
>>>>> 	regulator-min-microvolt = <1800000>;
>>>>> 	regulator-max-microvolt = <1800000>;
>>>>> };
>>>
>>> It really seems to be ldo7, otherwise there's no HDMI output. I don't
>>> have the schematics either.
>>>
>>> But it seems we have at least two other regressions in Linux next that
>>> prevent me from testing this properly:
>>>
>>> 1. On igepv5, I get this for the MMC regulator
>>>
>>> ldo9: bypassed regulator has no supply!
>>> ldo9: failed to get the current voltage(-517)
>>> palmas-pmic 48070000.i2c:palmas@48:palmas_pmic: failed to register 48070000.i2c:palmar
> 
> The patch I posted fixes this. Then for the HDMI see below.
> I've kept it at 2V like we have in omap5-board-common.dtsi,
> I wonder if it really should be 1.8V though for ldo7 in this
> case?

AFAIK the VDDA for the HDMI needs to be 1.8V along with other VDDAs for DSS
(vdda_dsiporta, vdda_dsiportc and vdda_hdmi).

Tomi: what do you think?

According to the OMAP5 data manual the vdda_hdmi can be in 1.5V or 1.8V mode,
2V is not mentioned in the recommended operating conditions table.

Just to note: on omap5-uevm the ldo7 is connected to VPP1 of OMAP5 (eFuse
power supply), which does require 2V.


> Regards,
> 
> Tony
> 8< -----------------
> From: Tony Lindgren <tony@atomide.com>
> Date: Thu, 5 May 2016 11:29:23 -0700
> Subject: [PATCH] ARM: dts: Fix ldo7 source for HDMI on igepv5
> 
> Fix ldo7 source for HDMI on igepv5.
> 
> Suggested-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
> diff --git a/arch/arm/boot/dts/omap5-igep0050.dts b/arch/arm/boot/dts/omap5-igep0050.dts
> index 46ecb1d..72ff6a4 100644
> --- a/arch/arm/boot/dts/omap5-igep0050.dts
> +++ b/arch/arm/boot/dts/omap5-igep0050.dts
> @@ -35,6 +35,12 @@
>  	};
>  };
>  
> +&ldo7_reg {
> +	status = "okay";
> +	regulator-min-microvolt = <2000000>;
> +	regulator-max-microvolt = <2000000>;

If we are not changing the default voltage set in the common dtsi file we only
need to status = "okay"

> +};
> +
>  &omap5_pmx_core {
>  	i2c4_pins: pinmux_i2c4_pins {
>  		pinctrl-single,pins = <
> 


-- 
Péter

Re: [PATCH] ARM: dts: omap5-igep0050: Correct hdmi regulator

[Tomi Valkeinen]

[-- Attachment #1.1: Type: text/plain, Size: 474 bytes --]


On 09/05/16 11:25, Peter Ujfalusi wrote:

> Tomi: what do you think?
> 
> According to the OMAP5 data manual the vdda_hdmi can be in 1.5V or 1.8V mode,
> 2V is not mentioned in the recommended operating conditions table.

I thought vdda_hdmi should always be 1.8V, but you're right, on omap5
1.5V is allowed according to DM. On later SoCs it's only 1.8V. I suggest
we use 1.8V on all boards, as that's what's known to work.

2V is definitely wrong.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] ARM: dts: omap5-igep0050: Correct hdmi regulator

[Tony Lindgren]

* Eduard Gavin <egavin@iseebcn.com> [160509 07:43]:
> Dear Nishanth,
>   In igepV5 the LDO7 is connected to:
>     VDDA_DSIPORTA - ball AA33
>     VDDA_DSIPORTC - ball AE33
>     VDDA_HDMI - ball AN25
>   LDO4 is connected to:
>     VPP1 - ball AD9

Thanks for the info, here's an updated patch with comments and now
using 1.8V instead of the 2.0V omap5-board-common.dtsi.

Regards,

Tony

8< -----------------
From: Tony Lindgren <tony@atomide.com>
Date: Mon, 9 May 2016 07:51:00 -0700
Subject: [PATCH] ARM: dts: Fix ldo7 source for HDMI on igepv5

Fix ldo7 source for HDMI on igepv5.

Suggested-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>

--- a/arch/arm/boot/dts/omap5-igep0050.dts
+++ b/arch/arm/boot/dts/omap5-igep0050.dts
@@ -35,6 +35,16 @@
 	};
 };
 
+/*
+ * LDO7 is used for HDMI: VDDA_DSIPORTA - ball AA33, VDDA_DSIPORTC - ball AE33
+ * VDDA_HDMI - ball AN25. LDO4 is: VPP1 - ball AD9.
+ */
+&ldo7_reg {
+	status = "okay";
+	regulator-min-microvolt = <1800000>;
+	regulator-max-microvolt = <1800000>;
+};
+
 &omap5_pmx_core {
 	i2c4_pins: pinmux_i2c4_pins {
 		pinctrl-single,pins = <

Re: [PATCH] ARM: dts: omap5-igep0050: Correct hdmi regulator

[Nishanth Menon]

On 05/12/2016 11:57 AM, Tony Lindgren wrote:
> * Eduard Gavin <egavin@iseebcn.com> [160509 07:43]:
>> Dear Nishanth,
>>   In igepV5 the LDO7 is connected to:
>>     VDDA_DSIPORTA - ball AA33
>>     VDDA_DSIPORTC - ball AE33
>>     VDDA_HDMI - ball AN25
>>   LDO4 is connected to:
>>     VPP1 - ball AD9
> 
> Thanks for the info, here's an updated patch with comments and now
> using 1.8V instead of the 2.0V omap5-board-common.dtsi.
> 
> Regards,
> 
> Tony
> 
> 8< -----------------
> From: Tony Lindgren <tony@atomide.com>
> Date: Mon, 9 May 2016 07:51:00 -0700
> Subject: [PATCH] ARM: dts: Fix ldo7 source for HDMI on igepv5
> 
> Fix ldo7 source for HDMI on igepv5.
> 
> Suggested-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> 
> --- a/arch/arm/boot/dts/omap5-igep0050.dts
> +++ b/arch/arm/boot/dts/omap5-igep0050.dts
> @@ -35,6 +35,16 @@
>  	};
>  };
>  
> +/*
> + * LDO7 is used for HDMI: VDDA_DSIPORTA - ball AA33, VDDA_DSIPORTC - ball AE33
> + * VDDA_HDMI - ball AN25. LDO4 is: VPP1 - ball AD9.

We should set ldo4_reg as 2v as well (default in omap5-board-common is
1.8v). VPP1 should be 2v to prevent efuse from being messed up.

> + */
> +&ldo7_reg {
> +	status = "okay";
> +	regulator-min-microvolt = <1800000>;
> +	regulator-max-microvolt = <1800000>;
> +};
> +
>  &omap5_pmx_core {
>  	i2c4_pins: pinmux_i2c4_pins {
>  		pinctrl-single,pins = <
> 


-- 
Regards,
Nishanth Menon

Re: [PATCH] ARM: dts: omap5-igep0050: Correct hdmi regulator

[Tony Lindgren]

* Nishanth Menon <nm@ti.com> [160512 12:21]:
> On 05/12/2016 11:57 AM, Tony Lindgren wrote:
> > + * LDO7 is used for HDMI: VDDA_DSIPORTA - ball AA33, VDDA_DSIPORTC - ball AE33
> > + * VDDA_HDMI - ball AN25. LDO4 is: VPP1 - ball AD9.
> 
> We should set ldo4_reg as 2v as well (default in omap5-board-common is
> 1.8v). VPP1 should be 2v to prevent efuse from being messed up.

Oh OK, here's the patch updated for ldo4.

Tony

8< --------------------
From: Tony Lindgren <tony@atomide.com>
Date: Thu, 12 May 2016 09:51:51 -0700
Subject: [PATCH] ARM: dts: Fix ldo7 source for HDMI on igepv5

Fix ldo7 source for HDMI on igepv5.

Suggested-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>

--- a/arch/arm/boot/dts/omap5-igep0050.dts
+++ b/arch/arm/boot/dts/omap5-igep0050.dts
@@ -35,6 +35,22 @@
 	};
 };
 
+/* LDO4 is VPP1 - ball AD9 */
+&ldo4_reg {
+	regulator-min-microvolt = <2000000>;
+	regulator-max-microvolt = <2000000>;
+};
+
+/*
+ * LDO7 is used for HDMI: VDDA_DSIPORTA - ball AA33, VDDA_DSIPORTC - ball AE33,
+ * VDDA_HDMI - ball AN25
+ */
+&ldo7_reg {
+	status = "okay";
+	regulator-min-microvolt = <1800000>;
+	regulator-max-microvolt = <1800000>;
+};
+
 &omap5_pmx_core {
 	i2c4_pins: pinmux_i2c4_pins {
 		pinctrl-single,pins = <