* [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the Makefile
@ 2016-05-12 10:10 Olliver Schinagl
[not found] ` <1463047851-2039-1-git-send-email-oliver-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Olliver Schinagl @ 2016-05-12 10:10 UTC (permalink / raw)
To: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, arm-DgEjT+Ai2ygdnm+yROfE0A
Cc: dev-3kdeTeqwOZ9EV1b7eY7vFQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Maxime Ripard, Chen-Yu Tsai,
Olliver Schinagl
commit 27dd9af6bc (ARM: dts: sunxi: Add a olinuxino-lime2-emmc added the new
emmc equipped) lime2 but forgot its Makefile.
This patch adds an entry to the Makefile.
Signed-off-by: Olliver Schinagl <oliver-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>
---
Changes since v0:
Added proper commit reference.
arch/arm/boot/dts/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 95c1923..07f4cf8 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -695,6 +695,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
sun7i-a20-olimex-som-evb.dtb \
sun7i-a20-olinuxino-lime.dtb \
sun7i-a20-olinuxino-lime2.dtb \
+ sun7i-a20-olinuxino-lime2-emmc.dtb \
sun7i-a20-olinuxino-micro.dtb \
sun7i-a20-orangepi.dtb \
sun7i-a20-orangepi-mini.dtb \
--
2.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the Makefile
[not found] ` <1463047851-2039-1-git-send-email-oliver-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>
@ 2016-05-13 7:48 ` Maxime Ripard
2016-05-13 8:07 ` Olliver Schinagl
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2016-05-13 7:48 UTC (permalink / raw)
To: Olliver Schinagl
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, arm-DgEjT+Ai2ygdnm+yROfE0A,
dev-3kdeTeqwOZ9EV1b7eY7vFQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Chen-Yu Tsai
[-- Attachment #1: Type: text/plain, Size: 565 bytes --]
Hi Olliver,
On Thu, May 12, 2016 at 12:10:51PM +0200, Olliver Schinagl wrote:
> commit 27dd9af6bc (ARM: dts: sunxi: Add a olinuxino-lime2-emmc added the new
> emmc equipped) lime2 but forgot its Makefile.
This is still not the right commit format, the commit title should be
around double quotes. checkpatch both reports an error for this and
tells you what the proper format is, so please remember to use it
before you're sending a patch.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the Makefile
2016-05-13 7:48 ` Maxime Ripard
@ 2016-05-13 8:07 ` Olliver Schinagl
0 siblings, 0 replies; 3+ messages in thread
From: Olliver Schinagl @ 2016-05-13 8:07 UTC (permalink / raw)
To: Maxime Ripard
Cc: Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, arm-DgEjT+Ai2ygdnm+yROfE0A,
dev-3kdeTeqwOZ9EV1b7eY7vFQ, devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Chen-Yu Tsai
and now i'm embarrassed and ashamed. Teaches me not to rush things,
right? i'll correct it and take some time to do it right. sorry maxime!
On 13-05-16 09:48, Maxime Ripard wrote:
> Hi Olliver,
>
> On Thu, May 12, 2016 at 12:10:51PM +0200, Olliver Schinagl wrote:
>> commit 27dd9af6bc (ARM: dts: sunxi: Add a olinuxino-lime2-emmc added the new
>> emmc equipped) lime2 but forgot its Makefile.
> This is still not the right commit format, the commit title should be
> around double quotes. checkpatch both reports an error for this and
> tells you what the proper format is, so please remember to use it
> before you're sending a patch.
>
> Thanks!
> Maxime
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-13 8:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-12 10:10 [PATCHv2] devicetree: sunxi: Add OLinuXino Lime2 eMMC to the Makefile Olliver Schinagl
[not found] ` <1463047851-2039-1-git-send-email-oliver-dxLnbx3+1qmEVqv0pETR8A@public.gmane.org>
2016-05-13 7:48 ` Maxime Ripard
2016-05-13 8:07 ` Olliver Schinagl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).